VSCODE-110: Enable linux tests with graphics workaround for credential store #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
force-pushed
the
VSCODE-110/linux-keytar-tests
branch
from
0b78f4b to
6edd482
Compare
added 7 commits
May 18, 2020 15:47
Anemy
force-pushed
the
VSCODE-110/linux-keytar-tests
branch
from
d03be8c to
89bf0cb
Compare
alenakhineika
approved these changes
May 18, 2020
src/extension.ts
Outdated
| import * as vscode from 'vscode'; | ||
|
|
||
| import { ext } from './extensionConstants'; | ||
| import { tryToCreateKeytar } from './utils/keytar'; |
There was a problem hiding this comment.
Maybe just createKeytar? Try catch adds the same meaning later.
| // in order to ensure we're not polluting the credential store | ||
| // and because its tough to get the credential store running on | ||
| // headless linux. | ||
| ext.keytarModule = new KeytarStub(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/VSCODE-110