Fix show more documents code lens argument passing #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarcon
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
showMoreDocumentsClickedreceives a list of arguments. The behavior of this changed where its not passing the 2nd and 3rd arguments. This PR passes them all in the first argument to ensure vscode passes them correctly.I'll write a quick test so this can't break in next pr.
Also in this pr, we hide the command
showActiveConnectionInPlaygroundfrom the command palette since it's an internally used command.Created https://jira.mongodb.org/browse/VSCODE-112 for better error messaging when disconnected.