fix(chat): add message content to blank message request VSCODE-626 #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-626
When the message sent to the ai is empty, like how folks will use /schema, we would receive an error:
unhandled status from server, please report the following request idThis only happens in non-insiders VSCode.
It looks to be fixed in insiders, but since we do want to release the extension now we should work around it. We're adding a not-empty message in those cases so it doesn't error. This is a bit of a hack, I think we'll improve this in a follow up (or remove it). We probably want the check closer to the actual model request.
Also adds a few logs around when we're making requests and get a response.