Skip to content

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented May 11, 2020

Description

Add the new connection event.

The ticket for tests: https://jira.mongodb.org/browse/VSCODE-113

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee! It'll be interesting to see how people use the extension - and where we can focus our attention.

Err I think some of the failing tests are things we should look at. Lets get them green before merging.

@alenakhineika alenakhineika merged commit ec33367 into master May 11, 2020
@alenakhineika alenakhineika deleted the VSCODE-111-add-new-connection-event branch May 11, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants