Skip to content

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented May 13, 2020

Description

  • Move preparing data for Segment to the telemetry controller to be able manage files at single place.
  • Send the playground saved event when a user saves a playground to disk. No properties needed.
  • Send the playground loaded event when a user loads a playground from disk.
  • Refactor tests to use async calls instead of multiple done() for a single test. Multiple done lead to a situation when a test can return false values because we do not know which done was called and if the assertion section was reached at all. Some tests take more than 3 seconds to finish, therefore I increased mocha timeout for controller tests. I can assume that before they were silently passing.

Screenshot 2020-05-14 at 11 40 32

Interesting that for windows the same tests take much less time.

Screenshot 2020-05-14 at 11 42 35

@Anemy do you have any ideas what can be a reason?

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika removed the WIP label May 14, 2020
@alenakhineika alenakhineika requested a review from Anemy May 14, 2020 09:44
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks good. Thanks for cleaning up these tests. In future we can write all tests like this then.

@alenakhineika alenakhineika merged commit 3d239bd into master May 14, 2020
@alenakhineika alenakhineika deleted the VSCODE-114-playground-saved-loaded branch May 14, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants