STREAMS-1964: Add old shell compatibility of BinData for JS Engine #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LijieZhang1998
commented
Oct 8, 2025
| }; | ||
|
|
||
| BinData.prototype.nativeToString = BinData.prototype.toString; | ||
| BinData.prototype.toString = function (encoding) { |
There was a problem hiding this comment.
The functionality of $function and new shell differs for toString(). Use const a = new BinData(0, 'SGVsbG8gV29ybGQ=') as an example. For $function, a.toString() returns BinData(0, 'SGVsbG8gV29ybGQ='). For new shell, it returns hello world. When encoding exists in the caller, they return the same result. Should we keep the behavior of existing $function or new shell.
There was a problem hiding this comment.
Well, the goal here is maximum compatibility with $function and the legacy shell, so this seems reasonable to me
addaleax
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/STREAMS-1964 contains the functions/properties added or modified.