PERF-2415 Fix InvalidDocument: key u'$_internalJsEmit' must not start with '$' #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyacb
approved these changes
Jun 21, 2021
Comment on lines
+1143
to
+1146
| if "metrics" in ss and "operatorCounters" in ss["metrics"] and "expressions" in ss["metrics"]["operatorCounters"]: | ||
| del ss["metrics"]["operatorCounters"]["expressions"] | ||
| if "metrics" in ss and "operatorCounters" in ss["metrics"] and "match" in ss["metrics"]["operatorCounters"]: | ||
| del ss["metrics"]["operatorCounters"]["match"] |
There was a problem hiding this comment.
Just a suggestion, but why not delete operatorCounters the way aggStageCounters is deleted above?
Suggested change
| if "metrics" in ss and "operatorCounters" in ss["metrics"] and "expressions" in ss["metrics"]["operatorCounters"]: | |
| del ss["metrics"]["operatorCounters"]["expressions"] | |
| if "metrics" in ss and "operatorCounters" in ss["metrics"] and "match" in ss["metrics"]["operatorCounters"]: | |
| del ss["metrics"]["operatorCounters"]["match"] | |
| if "metrics" in ss and "operatorCounters" in ss["metrics"]: | |
| del ss["metrics"]["operatorCounters"] |
There was a problem hiding this comment.
Thank you very much for reviewing! My thought here was to delete the minimal amount of info to fix this issue for both SERVER-56422 and SERVER-56602 (assuming we have other operationCounters). Either way it looks like a temp solution as other $-prefixed metrics may be added in the future, so we probably should look into other ways to handle it (I did created HELP-25443 to get better understanding where we are with support of $-prefixed metrics in pymango).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for "InvalidDocument: key u'$_internalJsEmit' must not start with '$'" (BF-21450). It handles new metrics introduced in SERVER-56422 (and others coming in SERVER-56602) the same way as other $-prefixed field were handled in get_server_status.
Here is the patch