Skip to content

Conversation

NoahStapp
Copy link
Collaborator

I brought over the most directly applicable utilities from langchain-mongodb and reworked or added tests. Feel free to suggest other utilities we want, this PR directly addresses only what's described in the ticket.

@NoahStapp NoahStapp requested a review from blink1073 September 9, 2025 17:11
embedding_field: str,
n_docs: int,
) -> bool:
"""Inserts texts using the provided insert_func and then waits for texts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text looks out of date

wait_until_complete: float | None = None,
**kwargs: Any,
) -> None:
"""Experimental Utility function to create an Atlas Search index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say these aren't experimental anymore

assert len(indexes) == 0


def test_search_index_update_vector_search_index(collection: Collection) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we'll have to skip this on local Atlas due to its limitations around update

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works locally using the Atlas CLI, https://jira.mongodb.org/browse/CLOUDP-275518 is completed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073
Copy link
Member

I ended up having to replicate much of the logic in bulk_embed_and_insert_texts in crewai.

@blink1073
Copy link
Member

Also the query logic: langchain, crewai

@NoahStapp
Copy link
Collaborator Author

@blink1073 adding utilities for those cases sounds good. I'd prefer to put those changes in separate PRs to reduce the review burden.

@NoahStapp NoahStapp requested a review from blink1073 September 9, 2025 17:32
@blink1073
Copy link
Member

I'd prefer to put those changes in separate PRs to reduce the review burden.

Yeah that works for me

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! Let's merge and iterate

@NoahStapp NoahStapp merged commit 8d776d8 into mongodb-labs:main Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants