-
Notifications
You must be signed in to change notification settings - Fork 4
INTPYTHON-598 - Create an AI/ML helper library #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pymongo_vectorsearch_utils/index.py
Outdated
embedding_field: str, | ||
n_docs: int, | ||
) -> bool: | ||
"""Inserts texts using the provided insert_func and then waits for texts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text looks out of date
pymongo_vectorsearch_utils/index.py
Outdated
wait_until_complete: float | None = None, | ||
**kwargs: Any, | ||
) -> None: | ||
"""Experimental Utility function to create an Atlas Search index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say these aren't experimental anymore
assert len(indexes) == 0 | ||
|
||
|
||
def test_search_index_update_vector_search_index(collection: Collection) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note we'll have to skip this on local Atlas due to its limitations around update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works locally using the Atlas CLI, https://jira.mongodb.org/browse/CLOUDP-275518 is completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I updated https://jira.mongodb.org/browse/INTPYTHON-317
I ended up having to replicate much of the logic in bulk_embed_and_insert_texts in crewai. |
@blink1073 adding utilities for those cases sounds good. I'd prefer to put those changes in separate PRs to reduce the review burden. |
Yeah that works for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks! Let's merge and iterate
I brought over the most directly applicable utilities from langchain-mongodb and reworked or added tests. Feel free to suggest other utilities we want, this PR directly addresses only what's described in the ticket.