Add aliases to resolve discrepancy in naming #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusgeo
changed the title
ShaneHarvey
requested changes
Aug 3, 2020
ShaneHarvey
reviewed
Aug 3, 2020
| # Alias | ||
| ExplainCollection = ExplainableCollection | ||
|
|
||
|
|
There was a problem hiding this comment.
I think there are some extra newlines here.
test/test_collection.py
Outdated
| except: | ||
| print("Could not import!") | ||
| assert False | ||
| assert ExplainableCollection == ExplainCollection |
There was a problem hiding this comment.
You can remove the try/excepts and use self.assertEqual instead of bare assert.
prashantmital
suggested changes
Aug 4, 2020
test/test_collection.py
Outdated
| try: | ||
| from pymongoexplain import ExplainCollection | ||
| except: | ||
| print("Could not import!") |
There was a problem hiding this comment.
You can replace these two lines with:
self.fail("Failed to import ExplainCollection from pymongoexplain")
test/test_collection.py
Outdated
| from pymongoexplain import ExplainableCollection | ||
| except: | ||
| print("Could not import!") | ||
| assert False |
test/test_collection.py
Outdated
| except: | ||
| print("Could not import!") | ||
| assert False | ||
| try: |
There was a problem hiding this comment.
Suggest leaving a newline between the two sub-tests to make this more readable.
prashantmital
approved these changes
Aug 4, 2020
| @@ -213,5 +213,11 @@ def test_cli_tool(self): | |||
| self.assertNotEqual(res.stdout, "") | |||
| self.assertTrue(res.returncode == 0) | |||
|
|
|||
| def test_imports(self): | |||
| from pymongoexplain import ExplainCollection | |||
ShaneHarvey
approved these changes
Aug 4, 2020
prashantmital
suggested changes
Aug 4, 2020
There was a problem hiding this comment.
I think after #33 is merged, you need to rebase this on top of master and add a changelog entry for the addition of the alias.
Done. |
prashantmital
approved these changes
Aug 5, 2020
ShaneHarvey
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.