Add MongoDB Extended JSON 2.0 support #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Dec 17, 2021
ShaneHarvey
requested changes
Dec 18, 2021
test/test_bsonjs.py
Outdated
| @@ -291,6 +291,25 @@ def test_load_throws_no_read_attribute(self): | |||
| not_file = {} | |||
| self.assertRaises(AttributeError, bsonjs.load, not_file) | |||
|
|
|||
| def test_extended(self): | |||
There was a problem hiding this comment.
We can rename this to test_mode now. Can you also add a test case for dump (not dumps) and also add a test for passing the mode as a non-keyword (ie positional) argument?:
bsonjs.dumps(bson_bytes, bsonjs.CANONICAL)
There was a problem hiding this comment.
Did you add the test for dump()?
src/bsonjs.c
Outdated
| } | ||
| else if(mode == 0){ | ||
| json = bson_as_json(b, json_len); | ||
| }else{ |
There was a problem hiding this comment.
Formatting of this if/else if/else block is still inconsistent.
There was a problem hiding this comment.
Sorry about that, done.
There was a problem hiding this comment.
This is still not resolved. Following the existing if/else statements in this file it should be:
if (mode == 1) {
json = bson_as_relaxed_extended_json(b, json_len);
} else if (mode == 2) {
json = bson_as_canonical_extended_json(b, json_len);
} else if (mode == 0) {
json = bson_as_json(b, json_len);
} else {
...
}
… positional argument
ShaneHarvey
requested changes
Dec 20, 2021
src/bsonjs.c
Outdated
| } | ||
| else if(mode == 0){ | ||
| json = bson_as_json(b, json_len); | ||
| }else{ |
There was a problem hiding this comment.
This is still not resolved. Following the existing if/else statements in this file it should be:
if (mode == 1) {
json = bson_as_relaxed_extended_json(b, json_len);
} else if (mode == 2) {
json = bson_as_canonical_extended_json(b, json_len);
} else if (mode == 0) {
json = bson_as_json(b, json_len);
} else {
...
}
src/bsonjs.c
Outdated
| }else if(mode == 0){ | ||
| json = bson_as_json(b, json_len); | ||
| }else{ | ||
| PyErr_SetString(PyExc_ValueError, "The value of extended must be one " |
ShaneHarvey
requested changes
Dec 20, 2021
ShaneHarvey
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.