Drop EOL Pythons #35
Merged
Drop EOL Pythons #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 17, 2021
ShaneHarvey
requested changes
Dec 17, 2021
There was a problem hiding this comment.
Nice, there still a few require changes and some nice to haves for this PR:
- update setup.py, python_requires, drop out of date classifiers, remove import multiprocessing workaround, remove ez_setup imports.
- remove ez_setup.py
- update build-wheels.sh script to skip python <3.6 similar to what we do for pymongo: https://github.com/mongodb/mongo-python-driver/blob/a94916edf10fddad3335ff14b55b83e27641ec14/.evergreen/build-manylinux-internal.sh#L14
- Remove PY_MAJOR_VERSION code from src/bsonjs.c.
- Remove sys.version_info specific code from the test suite.
…build-wheels.sh to skip older python versions
ShaneHarvey
previously requested changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.