Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for legacy deserialization #319

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

jamis
Copy link
Contributor

@jamis jamis commented Nov 30, 2023

Mongoid specs, for instance, rely on BSON::Binary defining only two instance variables, and build testing data around that assumption.

Mongoid specs, for instance, rely on BSON::Binary defining only two
instance variables, and build testing data around that assumption.
@jamis jamis requested a review from comandeo November 30, 2023 19:54
@jamis
Copy link
Contributor Author

jamis commented Nov 30, 2023

ruby 2.7 has some failures in evergreen when COMPACT is enabled, but I've confirmed locally that these failures happen even in master. I suspect a memory glitch in ruby 2.7, as the same specs work fine on later versions of ruby.

@jamis jamis merged commit 18c7e6c into mongodb:master Nov 30, 2023
38 of 40 checks passed
@jamis jamis deleted the binary-init_with branch November 30, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant