-
Notifications
You must be signed in to change notification settings - Fork 142
Possibly reduce crate size #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm, I didn't realize that these test files were being included in the final crate. I was under the impression that the Rust test files (e.g. src/tests/mod.rs) wouldn't be included due to them being annotated with |
#203 is merged, maybe it's time to close this issue if exclusion of the test in the package is enough. |
Yep, I think we can close this. Thanks again @darnuria! |
PR: #203
I ran
cargo diet --dry-run
(cargo diet project) on this crate and seems like it's possible to improve the size of the crate.By default test are incorporated in the final crate and it can size up significantly the final crate. The rational about that? Not everybody in the world have top notch internet acces or a huge amount of space on the disk.
If it's okay, I can do a pull-request about it.
Edit
Added link to pull-request
The text was updated successfully, but these errors were encountered: