Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to serde 0.9 #49

Closed
dtolnay opened this issue Jan 29, 2017 · 9 comments
Closed

Update to serde 0.9 #49

dtolnay opened this issue Jan 29, 2017 · 9 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented Jan 29, 2017

Check out the release notes here: https://github.com/serde-rs/serde/releases/tag/v0.9.0
@zonyitoo
Copy link
Contributor

Spent a morning trying to modify all the existing code for 0.9, what a pain!

zonyitoo added a commit that referenced this issue Feb 1, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
fc9ed31
zonyitoo added a commit that referenced this issue Feb 1, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
d9f01ec
zonyitoo added a commit that referenced this issue Feb 1, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
0c4ed07
zonyitoo added a commit that referenced this issue Feb 1, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
20dffee
zonyitoo added a commit that referenced this issue Feb 1, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
b130279
zonyitoo added a commit that referenced this issue Feb 1, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
55e5166
@dtolnay
Copy link
Contributor Author

dtolnay commented Feb 2, 2017

Are you planning to drop rustc-serialize support as part of this update now that serde derives are stable? Rustc-serialize has been deprecated for a long time and the toml and bincode crates are dropping it as part of the serde 0.9 update.

@zonyitoo
Copy link
Contributor

zonyitoo commented Feb 2, 2017

I don't have plan for this now. This can be discussed in the other issue.

@zonyitoo zonyitoo mentioned this issue Feb 2, 2017
Closed
@dtolnay
Copy link
Contributor Author

dtolnay commented Feb 2, 2017

Makes sense. I filed #51 to follow up.

@zonyitoo
Copy link
Contributor

zonyitoo commented Feb 2, 2017

@kyeah You may also want to take a look at this. If the last commit is Ok, I will merge it to master.

@kyeah
Copy link
Contributor

kyeah commented Feb 2, 2017

@zonyitoo just looked through it; two minor comments, but looks good otherwise. Thanks for updating all those dependencies!

zonyitoo added a commit that referenced this issue Feb 3, 2017
@zonyitoo
[#49] Initially migrating to serde0.9, update other dependencies
be922fa
@zonyitoo
Copy link
Contributor

zonyitoo commented Feb 3, 2017

Already updated. I will merge this if it is Ok.

@kyeah
Copy link
Contributor

kyeah commented Feb 3, 2017

looks good 👍

@zonyitoo zonyitoo closed this as completed Feb 3, 2017
@zonyitoo
Copy link
Contributor

zonyitoo commented Feb 3, 2017

Already published as v0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zonyitoo @dtolnay @kyeah