Skip to content

Add Decimal128 support #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2019
Merged

Add Decimal128 support #118

merged 5 commits into from
Mar 14, 2019

Conversation

lrlna
Copy link
Contributor

@lrlna lrlna commented Feb 28, 2019

Hello!

I wanted to pull in the work @zonyitoo has done in the past to allow support for Decimal128.

This PR:

  • rebases that work over to master,
  • includes a few more tests
  • a serialization + deserialization for BSON Decimal128 type
  • a few docs
  • and two more methods for decimal128 -> i32 and u32 conversions.

@saghm and @kyeah if either of you have time for a review, I would really appreciate it.

Thank you for your time!

@zonyitoo zonyitoo requested a review from kyeah March 1, 2019 13:36
@zonyitoo zonyitoo merged commit 68a8e07 into mongodb:master Mar 14, 2019
@zonyitoo
Copy link
Contributor

LGTM. Merge now.

@lrlna lrlna deleted the dec128 branch February 27, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants