Fix building on ARM arch #132
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
bson-rs
has a depending cratedecimal
which may using with optional feature "decimal128". Buildingdecimal
(last version 2.0.4) is terminating with error on ARM arch when I runcargo build --features="decimal128"
The reason is the difference representation
c_char
type by two different platforms:c_char
isi8
onx86
\amd64
and isu8
onarm
.I guess you want ask me why I write here and don't create an issue inside 'decimal' repository. The fact is
decimal
crate already has a merged PR alkis/decimal#42 for fix that, however fixed version hasn't released. The trouble is, @alkis, author of the crate, has no active since April and I have no idea how much time we will not be able to get a fixed version on crates.io.So, I suggest change source of the depending crate from crates.io to git commit with fixed compile error. It is the fastest and more safety path to resolve the problem.
On the other hand it is possible to migrate on another crate, for example, rust_decimal or other. It will be more complex and require some code changes for apply new library API.