Cleanup deps #137
Cleanup deps #137
Conversation
Cargo.toml
Outdated
| rand = "0.7" | ||
| serde = "1.0" | ||
| serde_json = { version = "1.0", features = ["preserve_order"] } | ||
| time = "0.1" | ||
| linked-hash-map = "0.5" | ||
| hex = "0.3" |
There was a problem hiding this comment.
Hey @AdminXVII would you be able to update hex to 0.4, in case your PR gets merged? I wanted to update it, but then saw your PR
There was a problem hiding this comment.
Yeah I think I could update the PR during the week. I'll get back to you soon.
There was a problem hiding this comment.
It was easier than I thought, it's already rebased. Tell me if there is anything you want me to do.
AdminXVII
force-pushed
the
cleanup-deps
branch
from
68d9d7d to
47e87d5
Compare
|
@AdminXVII due to the large number of code changes since this PR was filed, I went ahead and did the rebase myself rather than put you through it. Would you be able to take a look at the code as it is now to verify that I properly preserved all of the changes you made? |
|
Yeah I think that does the same job. |
|
Awesome, thanks! The lint failure should be addressed by #200, so I've added the rest of the team to the review so we can get this merged! |
Remove dependencies where possible.
- The byteorder crate can be replaced by the std {to,from}_{le,be}_bytes since rust 1.32.0.
- The time crate can be replaced with SystemTime.
- The libc and md5 crates were not used at all.
- Remove features not needed from chrono
- the hex dependency was outdated
**BREAKING CHANGE**: Requires at least Rust 1.32.0
{to,from}_{le,be}_bytesfunctions on integers