minor: fix new clippy lint failures with rust 1.42.0 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghm
commented
Mar 12, 2020
| DecoderError::FromUtf8Error(ref inner) => inner.description(), | ||
| DecoderError::IoError(ref inner) => | ||
| { | ||
| #[allow(deprecated)] |
There was a problem hiding this comment.
Error::description has been deprecated in Rust 1.42, and clippy suggests using to_string(), but unfortunately we aren't able to here since we're returning a reference, and the newly-allocated string returned by to_string() won't live long enough. We probably will want to get rid of our own description implementations before 1.0, but for now, I've just annotated each of these calls to suppress the deprecation warning.
There was a problem hiding this comment.
Can you file a ticket for dropping the description implementations?
There was a problem hiding this comment.
patrickfreed
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.