Skip to content

RUST-318 Remove Document::insert_bson #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

saghm
Copy link
Contributor

@saghm saghm commented Apr 3, 2020

No description provided.

@saghm saghm force-pushed the RUST-318 branch 2 times, most recently from 2b0cc59 to b2eb5c7 Compare April 3, 2020 20:21
@saghm saghm marked this pull request as ready for review April 3, 2020 20:33
@saghm saghm requested a review from patrickfreed April 3, 2020 20:33
Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of this diff appears to be formatting changes. do you think it's worth splitting it up into two commits, one of which is a minor one for formatting and the other with the insert_bson changes?

@saghm
Copy link
Contributor Author

saghm commented Apr 6, 2020

Oops, didn't realize that rustfmt did a number on this file. I think I missed this when initially formatting the project because it's technically a separate crate from the rest of the library. I've added a minor commit that formats and fixes the clippy lints in serde-tests as well as adds it to the evergreen scripts so it will get verified in CI from now on.

@saghm saghm merged commit 46109d8 into mongodb:master Apr 8, 2020
@saghm saghm deleted the RUST-318 branch April 8, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants