Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-313 Mark enums as non-exhaustive where appropriate #169

Merged
merged 1 commit into from May 14, 2020

Conversation

saghm
Copy link
Contributor

@saghm saghm commented May 14, 2020

No description provided.

@saghm saghm marked this pull request as ready for review May 14, 2020 18:20
@saghm saghm requested a review from patrickfreed May 14, 2020 18:20
Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mark Bson as non-exhaustive too if we want this library to be 1.x forever. New BSON types are really rare though, and there may be value in allowing users to exhaustively switch on the current set of available types.

@saghm
Copy link
Contributor Author

saghm commented May 14, 2020

I think when we triaged this ticket, we decided not to put it on BSON. I think that bumping the major version if/when new BSON types are created is a small cost that's worth it to make it easier for users to use Bson in an exhaustive fashion.

@saghm
Copy link
Contributor Author

saghm commented May 14, 2020

Despite it saying there were merge conflicts, rebasing locally didn't give any conflicts. Another point for team rebase.

@saghm saghm merged commit 4689d15 into mongodb:master May 14, 2020
@saghm saghm deleted the RUST-313 branch May 14, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants