fix: Don't use the type for constants; use std #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the rustfmt lint is failing; the instructions for setting up this test locally are here. |
|
Oh - apologies. Should be fixed. |
|
No worries! |
saghm
approved these changes
Jun 5, 2020
patrickfreed
approved these changes
Jun 5, 2020
isabelatkinson
approved these changes
Jun 5, 2020
|
Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple cases where a primitive type was being used as a module, like
f64::NAN. This was fixed by using thestdmodule, likestd::f64::NAN.fixes #185