minor: fix clippy #224
Merged
minor: fix clippy #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
commented
Jan 4, 2021
| @@ -27,6 +27,7 @@ fn byte_string_oid() { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[allow(clippy::eq_op)] | |||
There was a problem hiding this comment.
eq_op produces a warning when something is compared to itself, but we need to do that in this test.
saghm
approved these changes
Jan 4, 2021
| @@ -212,7 +212,7 @@ pub(crate) fn deserialize_bson_kvp<R: Read + ?Sized>( | |||
| Some(ElementType::Array) => deserialize_array(reader, utf8_lossy).map(Bson::Array)?, | |||
| Some(ElementType::Binary) => { | |||
| let mut len = read_i32(reader)?; | |||
| if len < 0 || len > MAX_BSON_SIZE { | |||
| if !(0..=MAX_BSON_SIZE).contains(&len) { | |||
There was a problem hiding this comment.
Interesting, I find this far less readable, and it seems like it would be slower (since it has to do a linear search rather than two comparisons), but if clippy wants it this way, who am I to argue?
patrickfreed
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.