RUST-647 Sync spec tests for invalid relaxed UUIDs #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
commented
Jan 26, 2021
| @@ -173,42 +173,21 @@ pub(crate) struct Uuid { | |||
| } | |||
|
|
|||
| impl Uuid { | |||
| pub(crate) fn parse(mut self) -> extjson::de::Result<crate::Binary> { | |||
| if !valid_uuid_format(&self.value) { | |||
There was a problem hiding this comment.
The checks in valid_uuid_format do not account for extraneous hyphens (covered in this new test). Since we added the uuid crate as a dependency when implementing the serde helpers, I switched this method to parse into a uuid::Uuid rather than do the work manually.
isabelatkinson
force-pushed
the
RUST-647
branch
from
5b07ab8 to
748e913
Compare
patrickfreed
approved these changes
Jan 26, 2021
saghm
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.