-
Notifications
You must be signed in to change notification settings - Fork 148
RUST-282 Add pretty-printed Debug
implementation to Document
#262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debug
implementation to Document
Debug
implementation to Document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, just one small formatting request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tagging in Patrick for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a test suggestion and request for an existing but related issue to be fixed.
I modified the This means that instead of printing out
it will print them out as
or
depending on the format specifier. This is an easy fix if we want to follow the pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job with this, especially with handling all the more ambiguous cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!
It looks like the only relevant struct which doesn't derive
Debug
isDocument
, so I added support for pretty-print there.I also added a test to the end of bson.rs test.