Double canonical extended json fraction fails round trip on Deserialize from_slice #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ittorchbearer
changed the title
ittorchbearer
changed the title
|
Thanks for catching this and sending a fix! I've merged it and it'll go out with the next release. |
abr-egn
pushed a commit
to abr-egn/bson-rust
that referenced
this pull request
Jan 9, 2023
abr-egn
added a commit
that referenced
this pull request
Jan 10, 2023
abr-egn
added a commit
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was a bug as try_from has this functionality--while from_slice had functionality that failed on fractions. Either this is the proper decode fix, or the encoding needs fixed where .fract() adds ".0" to string.