RUST-1798 use simd to optimize utf8 validation #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Liyixin95 <601947961@qq.com>
abr-egn
commented
Jun 3, 2025
| @@ -44,7 +42,7 @@ pub enum ErrorKind { | |||
| MalformedValue { message: String }, | |||
|
|
|||
| /// Improper UTF-8 bytes were found when proper UTF-8 was expected. | |||
| Utf8EncodingError(Utf8Error), | |||
There was a problem hiding this comment.
The error value provided by simdutf8::basic::from_utf8 is zero-sized (because it omits tracking error location in favor of speed) so I didn't see much reason to capture it here; this also means we're not exposing a 0.x crate type in our public API.
isabelatkinson
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1798
Our string parsing has changed pretty significantly since #440 was opened, so I opted to create a new PR rather than try to rebase and rework that one.