RUST-2251 document and tidy up serde helpers #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Aug 19, 2025
| @@ -496,31 +491,6 @@ impl<T: chrono::TimeZone> From<chrono::DateTime<T>> for crate::DateTime { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(all(feature = "chrono-0_4", feature = "serde_with-3"))] | |||
| impl<'de> serde_with::DeserializeAs<'de, chrono::DateTime<Utc>> for crate::DateTime { | |||
There was a problem hiding this comment.
DeserializeAs/SerializeAs are supposed to only be implemented for container types or converter types, not leaf value types; this was essentially tagging crate::DateTime as a converter type for itself.
There was a problem hiding this comment.
the updated docs look great! I have a few additional random suggestions from poking around in the generated docs: isabelatkinson@3c9ebc0
abr-egn
force-pushed
the
RUST-2251/serde-helpers-doc
branch
from
3c9ebc0 to
f721029
Compare
abr-egn
force-pushed
the
RUST-2251/serde-helpers-doc
branch
from
f721029 to
7b3ebec
Compare
Applied, thanks :). I can't seem to both fix the merge conflict and preserve the verified status of your patch but I think since it's verified with my key it's fine? |
isabelatkinson
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2251
This adds toplevel documentation to the
serde_helpersmodule; I also removed some now-redundant (and, I think, arguably incorrect)serde_withtrait impls from elsewhere and made it so that the converters can be used withoutserde_with.