Skip to content

INTPYTHON-407 Add evergreen configuration for django-mongodb #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from Jibola November 5, 2024 13:36
@timgraham
Copy link
Collaborator

@blink1073
Copy link
Member Author

blink1073 commented Nov 5, 2024

  • Does this take the place of .ghub/workflows/tests.yml? (I don't see that status reported anymore.)
    • No, because those are publicly available
  • Are the results of evergreen builds not publicly available? (e.g. for non-employee contributors)
    • No
  • Have we lost the path filtering functionality to avoid unneeded builds?
    • No, that's why the test.yml file didn't run for this PR. Evergreen has different filtering.
  • The build uses Python 3.11 but it would be better to use 3.10 since that's the minimum version supported by Django 5.0.
    • Sure, I'll set it to 3.10 explicitly
  • It appears I don't have access to the Jira ticket, so perhaps I'm missing some explanation about this.
    • This is part of setting up Software Security Design Lifecycle compliance for the repo

@timgraham
Copy link
Collaborator

Thanks for the explanations. It looks good to me, but I'll leave the approval to Jib.

May I ask that when using GitHub's "squash and merge" button, please clear the "extended description" box that automatically includes a bulleted list of every commit that was squashed (e.g. fba8892)? We don't need that info cluttering our git log. Thanks.

@blink1073
Copy link
Member Author

Yep, I use refined github's pr-first-commit-title to do that automatically.

Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit b660425 into mongodb:main Nov 6, 2024
5 checks passed
@blink1073 blink1073 deleted the INTPYTHON-407 branch November 6, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants