-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-43570-mongosync-1.9.0 #470
DOCSP-43570-mongosync-1.9.0 #470
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/release-notes/1.9.txt
Outdated
|
||
**Upcoming** | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Embedded verifier content will live here once #339 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Ali, this looks good to me. I just added two more points to the downstream changes doc. Sorry for the late additions: Under general release notes, REP-5162: Added a stdin disclaimer to the mongosync executable regarding verification. Users will need to accept this disclaimer before mongosync will run. REP-5196: Added --acceptDisclaimer flag to bypass the disclaimer for users that have previously read the disclaimer. These will both be documented in #339 in the relevant sections. |
LGTM, thanks! I'm going to tag one of our leads to do a quick review. |
source/release-notes/1.9.txt
Outdated
|
||
Fixed Issues: | ||
|
||
- Fixed a bug introduced in ``mongosync`` 1.8.0 where ``mongosync`` would crash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already included in the 1.8.1 release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think we need it (even though it was included in the downstream changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I'll remove it!
verification. Users must to accept this disclaimer before ``mongosync`` | ||
can run. | ||
|
||
- Added ``--acceptDisclaimer`` flag for users that have previously read the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be documented in the configuration section too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is already in #339. Staging link at https://deploy-preview-339--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/#global-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the note corresponding to:
[REP-5163](https://jira.mongodb.org/browse/REP-5163): Add memory check in /start endpoint for enabling verification. The memory requirement is 0.5 GB per 1 million docs, plus 10 GB of base memory requirement.
DESCRIPTION
Add release notes for 1.9.0
See note on embedded verifier content.
STAGING
https://deploy-preview-470--docs-cluster-to-cluster-sync.netlify.app/release-notes/1.9/#1.9.0-release
JIRA
https://jira.mongodb.org/browse/DOCSP-43570