Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

amalhotra-mdb
Copy link
Collaborator

@amalhotra-mdb amalhotra-mdb commented Nov 11, 2024

DESCRIPTION

Adds a sentence to the top-level page of C2C docs that links to the new considerations for continuous sync section, in order to appropriately set user expectations around what's feasible with mongosync today.

Deletes this redundant sentence:

In addition to continuous data synchronization, mongosync can also facilitate a one time data migration between clusters.

STAGING

https://deploy-preview-478--docs-cluster-to-cluster-sync.netlify.app/

JIRA

https://jira.mongodb.org/browse/DOCSP-44974

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 51aa46a
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67336eb66305ff000893f9cc
😎 Deploy Preview https://deploy-preview-478--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % one non-blocking suggestion!

source/index.txt Outdated
{+c2c-product-name+} provides continuous data synchronization or a
one-time data migration between MongoDB clusters. You can enable
{+c2c-product-name+} with the :ref:`mongosync <c2c-mongosync>` utility.
one-time data migration between MongoDB clusters. See the :ref:`<mongosync-considerations>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] We typically follow the sentence structure of "to do x, see y," so I'd recommend swapping around the clauses on this second sentence:

Suggested change
one-time data migration between MongoDB clusters. See the :ref:`<mongosync-considerations>`
one-time data migration between MongoDB clusters. For current considerations on ``mongosync`` usage, see the :ref:`<mongosync-considerations>`

source/index.txt Outdated
one-time data migration between MongoDB clusters. You can enable
{+c2c-product-name+} with the :ref:`mongosync <c2c-mongosync>` utility.
one-time data migration between MongoDB clusters. For current considerations on
``mongosync`` usage, see the :ref:`<mongosync-considerations>` page. You can

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rephrasing to, "For notes and caveats on continuous sync, see the ___ page"

@ajhuh-mdb ajhuh-mdb merged commit ed326da into mongodb:master Nov 12, 2024
4 checks passed
amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Nov 12, 2024
…ngodb#478)

* DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync

* reviewer changes

* rephrase

* typo
ajhuh-mdb pushed a commit that referenced this pull request Nov 12, 2024
…) (#479)

* DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync

* reviewer changes

* rephrase

* typo
amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Nov 13, 2024
…ngodb#478)

* DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync

* reviewer changes

* rephrase

* typo
sarah-olson-mongodb pushed a commit that referenced this pull request Nov 13, 2024
…) (#480)

* DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync

* reviewer changes

* rephrase

* typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants