This repository was archived by the owner on May 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync #478
Merged
ajhuh-mdb
merged 4 commits into
mongodb:master
from
amalhotra-mdb:DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync
Nov 12, 2024
Merged
DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync #478
ajhuh-mdb
merged 4 commits into
mongodb:master
from
amalhotra-mdb:DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync
Nov 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajhuh-mdb
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % one non-blocking suggestion!
source/index.txt
Outdated
{+c2c-product-name+} provides continuous data synchronization or a | ||
one-time data migration between MongoDB clusters. You can enable | ||
{+c2c-product-name+} with the :ref:`mongosync <c2c-mongosync>` utility. | ||
one-time data migration between MongoDB clusters. See the :ref:`<mongosync-considerations>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] We typically follow the sentence structure of "to do x, see y," so I'd recommend swapping around the clauses on this second sentence:
Suggested change
one-time data migration between MongoDB clusters. See the :ref:`<mongosync-considerations>` | |
one-time data migration between MongoDB clusters. For current considerations on ``mongosync`` usage, see the :ref:`<mongosync-considerations>` |
source/index.txt
Outdated
one-time data migration between MongoDB clusters. You can enable | ||
{+c2c-product-name+} with the :ref:`mongosync <c2c-mongosync>` utility. | ||
one-time data migration between MongoDB clusters. For current considerations on | ||
``mongosync`` usage, see the :ref:`<mongosync-considerations>` page. You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest rephrasing to, "For notes and caveats on continuous sync, see the ___ page"
edobranov
approved these changes
Nov 12, 2024
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Nov 12, 2024
…ngodb#478) * DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync * reviewer changes * rephrase * typo
ajhuh-mdb
pushed a commit
that referenced
this pull request
Nov 12, 2024
…) (#479) * DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync * reviewer changes * rephrase * typo
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Nov 13, 2024
…ngodb#478) * DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync * reviewer changes * rephrase * typo
sarah-olson-mongodb
pushed a commit
that referenced
this pull request
Nov 13, 2024
…) (#480) * DOCSP-44974-cluster-to-cluster-considerations-for-continuous-sync * reviewer changes * rephrase * typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Adds a sentence to the top-level page of C2C docs that links to the new considerations for continuous sync section, in order to appropriately set user expectations around what's feasible with mongosync today.
Deletes this redundant sentence:
STAGING
https://deploy-preview-478--docs-cluster-to-cluster-sync.netlify.app/
JIRA
https://jira.mongodb.org/browse/DOCSP-44974
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?