Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

ajhuh-mdb
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb commented Dec 11, 2024

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 12064cf
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/6764657f96fb750008a25388
😎 Deploy Preview https://deploy-preview-522--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajhuh-mdb thanks for these updates! Looks good so far - just have some comments and suggestions for your consideration.

@ajhuh-mdb
Copy link
Collaborator Author

Thanks for the initial review @jeff-allen-mongo. This should be ready for another look.

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a final suggestion. Thanks @ajhuh-mdb!

@ajhuh-mdb
Copy link
Collaborator Author

Hi @ajayvijayakumar123 👋 Could you review this docs PR for documenting the Older Version Support limitations? I also left a comment open above for you. TIA!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things!

@ajhuh-mdb ajhuh-mdb changed the base branch from master to feature-older-version-support December 16, 2024 15:57
Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also tagging @mvankeulen94

@@ -0,0 +1,43 @@
- Writes that produce DDL events cannot occur on the source cluster during the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a link to the definition of DDL?

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this! a couple comments from my end

- :ref:`/reverse <c2c-api-reverse>` endpoint is not supported. You can't
enable the ``reversible`` option in the :ref:`/start <c2c-api-start>` request.

- You can't enable the ``enableUserWriteBlocking`` option in the ``/start``

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a note here that the user is responsible for preventing writes to the source or destination?

Copy link
Collaborator Author

@ajhuh-mdb ajhuh-mdb Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvankeulen94 @ajayvijayakumar123 do we have a way of ensuring users don't write to their clusters without the enableUserWriteBlocking option? Or is this something they just need to manually make sure of?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they just need to manually make sure

request.

- You can't enable the ``createSupportingIndexes`` :ref:`sharding parameter
<c2c-api-start-sharding>`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajayvijayakumar123 is there a workaround we can advise for users? It's tricky to digest what this parameter does if the reader isn't already familiar with it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Let's say the user wants to shard on shard key a:1. Instead of enabling createSupportingIndexes, the user would need to create an index to support the shard key on the source.


- Indexes with inconsistent specs or that are missing on some shards are not
supported. To check for index inconsistencies, see
:ref:`manage-indexes-find-inconsistent-indexes`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajayvijayakumar123 is this a change from status quo mongosync GA? We have 'mongosync only syncs indexes that have consistent index specifications on all shards.' in the limitations today

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. For 6.0+ migrations, mongosync ignores inconsistent indexes and just doesn't build them on the destination. For pre-6.0 migrations, mongosync will error on these indexes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make it clear that it'll error on pre-6.0 migrations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm


- Indexes with inconsistent specs or that are missing on some shards are not
supported. To check for index inconsistencies, see
:ref:`manage-indexes-find-inconsistent-indexes`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ajhuh-mdb ajhuh-mdb merged commit aa418bf into mongodb:feature-older-version-support Dec 19, 2024
4 checks passed
ajhuh-mdb added a commit that referenced this pull request Jan 28, 2025
* DOCSP-45860-older-version-limitations (#522)

* DOCSP-45860-older-version-limitations

* *

* JA feedback

* *

* *

* *

* AV feedback

* MvK feedback

* DOCSP-45859 Version Compatibility (#518)

* DOCSP-45859 Version Compatibility

* *

* *

* *

* AV feedback

* swap list order

* MvK feedback

* DOCSP-45861 Older Version Support Task Page (#533)

* DOCSP-45861 Older Version Support Task Page

* add prerequisites & limitations

* *

* *

* procedures

* *

* rn

* *

* remove extra step

* nit

* AV feedback

* remove task page

* *

* *

* *

* DOCSP-45862 User permissions older version (#552)

* DOCSP-45862-user-permissions

* *

* JD feedback

* AV feedback

* DOCSP-45863-embedded-verifier-migrations (#557)

* DOCSP-45863-embedded-verifier-migrations

* *

* *

* AV feedback

* wording

* add ddl limitation

* *

* RS feedback

* *

* remove merge conflict artifact

* fix link title
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants