Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

elyse-mdb
Copy link
Collaborator

@elyse-mdb elyse-mdb commented Dec 16, 2024

DESCRIPTION

Per this Slack thread, mongosync’s docs should specifically address mid-migration load level adjustments.

Suggested text:

You can adjust mongosync’s load level during a migration. To do this, terminate all mongosync processes, then restart them with the needed load level. Mongosync will resume roughly where it was before you ended the earlier processes.

  • This same procedure can be used to update any configuration setting other than --cluster0, --cluster1, and --id. To document this, I added a new section to the Configuration reference page with directions on how to update configuration settings during an active sync.
  • Linked to the above section on each adjustable configuration setting on the mongosync reference page.
  • Added an FAQ entry that links users to the above section.

STAGING

Configuration
mongosync
FAQ

JIRA

DOCSP-45558

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 7f8ea57
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67816e01c3ef1f0008529537
😎 Deploy Preview https://deploy-preview-530--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elyse-mdb elyse-mdb force-pushed the DOCSP-45558-midMigrationLoadChange branch from ded05a2 to a828c63 Compare January 7, 2025 00:31
@elyse-mdb elyse-mdb force-pushed the DOCSP-45558-midMigrationLoadChange branch from 294fa28 to c93dc3d Compare January 7, 2025 18:54
@jwilson-mdb jwilson-mdb self-requested a review January 7, 2025 22:31
Copy link
Collaborator

@jwilson-mdb jwilson-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this came out great!! The configuration page looks to be a good home for reconfiguring, and the crosslinking seems pretty intuitive to me. Nice job.

I left a couple of small suggestions for you to review/update before requesting an ext review, but overall LGTM!

using a configuration file. The configuration file contains settings that are
the equivalent of ``mongosync`` command line options.

During a migration, you can reconfigure certain ``mongosync`` options by following the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Consistency/clarity]
I realize that the current content uses both "settings" and "options" (from command line options), but i think it may be best to stick with "settings" on this page for consistency.

Suggested change
During a migration, you can reconfigure certain ``mongosync`` options by following the
During a migration, you can reconfigure certain ``mongosync`` settings by following the

Settings
~~~~~~~~

The following settings can be set from a configuration file to configure ``mongosync`` at startup.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Active Voice]

Rephrase to eliminate passive voice ("can be set") style guide

Suggested change
The following settings can be set from a configuration file to configure ``mongosync`` at startup.
You can configure the following ``mongosync`` settings at startup by using a configuration file.


Options
=======
To set these settings from the command line, see :ref:`c2c-cli-options`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional / nit]

Optional rephrasing to avoid the set/setting repetition

Suggested change
To set these settings from the command line, see :ref:`c2c-cli-options`.
To configure ``mongosync`` from the command line, see :ref:`c2c-cli-options`.

--cluster1 "<cluster1_connection_string>" \
--loadLevel <newLevel>

To learn more, see :ref:`Initialize mongosync <c2c-initialize>`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit / optional 😄 ]

Nothing wrong with "To learn more", but I think we tend to lean towards "For more information" in the server docs.


.. include:: /includes/opts/disableTelemetry

To disable telemetry data collection during a migration,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question / optional]

Would it make more sense to change the order slightly here and put the configuration file link before the link to reconfigure during a migration?

Maybe an SME can chime in, but my initial thought is someone viewing this page may find the configuration file link more relevant/useful than the reconfiguration instructions.

I'm not too sure how often someone might need to reconfigure so this is a weakly held opinion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going back and forth with the ordering, so I appreciate the feedback. I agree with your reasoning here, so I moved the reconfig link below the config file link!

Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I have a couple small-ish points; see what you think.


.. important::

You can't adjust the :setting:`cluster0`, :setting:`cluster1`, or :setting:`id` settings during a migration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this list going to need further updates as further settings are added?

Something like this might be more maintainable:

Only the following settings are adjustable during a migration. Others MUST remain unchanged between mongosync restarts.

.. procedure::
:style: normal

.. step:: (Optional) Pause the ``mongosync`` processes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of doing this versus just terminating the mongosync processes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tip in this step (borrowed from the mongosync Live Upgrade tutorial) describes a reason why users might want to pause before terminating:

If you don't want to immediately resume data synchronization operations after live upgrade, consider pausing the mongosync processes. This is useful if you're coordinating operations from multiple mongosync processes.

Please let me know if you think this tip is not true or helpful! If that's the case, then I can remove this step and update the final step.

@elyse-mdb elyse-mdb requested review from FGasper and removed request for FGasper January 10, 2025 23:52
@elyse-mdb elyse-mdb merged commit ccd72ea into mongodb:master Jan 14, 2025
4 checks passed
@elyse-mdb elyse-mdb deleted the DOCSP-45558-midMigrationLoadChange branch January 14, 2025 14:54
@elyse-mdb elyse-mdb changed the title (DOCSP-45558) [C2C] Mention altering load level during a migration in mongosync’s documentation. (DOCSP-45558)-Mention-altering-load-level-during-a-migration-in-mongosync’s-documentation. Jan 14, 2025
@elyse-mdb elyse-mdb changed the title (DOCSP-45558)-Mention-altering-load-level-during-a-migration-in-mongosync’s-documentation. (DOCSP-45558)-Mention-altering-load-level-during-a-migration-in-mongosync’s-documentation Jan 14, 2025
elyse-mdb added a commit to elyse-mdb/docs-cluster-to-cluster-sync that referenced this pull request Jan 14, 2025
… mongosync’s documentation. (mongodb#530)

* (DOCSP-45558) Add section to FAQ page.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Procedure.

* (DOCSP-45558) Edit formatting.

* (DOCSP-45558) Edits.

* (DOCSP-45558) edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Add pause step to FAQ and edit FAQ link.

* (DOCSP-45558) Add update section to configuration page.

* (DOCSP-45558) Standardize link to update documentation.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Normalize links.

* (DOCSP-45558) Edit introduction to Optionsgst
q

* (DOCSP-45558) Edit Settings introduction.

* (DOCSP-45558) Updates.

* (DOCSP-45558) Make consistent intros to command line opts vs config file settings.

* (DOCSP-45558) Edit wording.

* (DOCSP-45558) Shorten sentence.

* (DOCSP-45558) updates.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edit important admonition.

* (DOCSP-45558) @jwilson-mdb Review changes.

* (DOCSP-45558) Add command line options to configuration intro.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) @FGasper Review changes.

(cherry picked from commit ccd72ea)
elyse-mdb added a commit to elyse-mdb/docs-cluster-to-cluster-sync that referenced this pull request Jan 14, 2025
… mongosync’s documentation. (mongodb#530)

* (DOCSP-45558) Add section to FAQ page.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Procedure.

* (DOCSP-45558) Edit formatting.

* (DOCSP-45558) Edits.

* (DOCSP-45558) edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Add pause step to FAQ and edit FAQ link.

* (DOCSP-45558) Add update section to configuration page.

* (DOCSP-45558) Standardize link to update documentation.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Normalize links.

* (DOCSP-45558) Edit introduction to Optionsgst
q

* (DOCSP-45558) Edit Settings introduction.

* (DOCSP-45558) Updates.

* (DOCSP-45558) Make consistent intros to command line opts vs config file settings.

* (DOCSP-45558) Edit wording.

* (DOCSP-45558) Shorten sentence.

* (DOCSP-45558) updates.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edit important admonition.

* (DOCSP-45558) @jwilson-mdb Review changes.

* (DOCSP-45558) Add command line options to configuration intro.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) @FGasper Review changes.

(cherry picked from commit ccd72ea)
@elyse-mdb
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.9
v1.8

Questions ?

Please refer to the Backport tool documentation

elyse-mdb added a commit that referenced this pull request Jan 14, 2025
…sync’s-documentation-v1.8-backport (530) (#547)

* (DOCSP-45558) [C2C] Mention altering load level during a migration in mongosync’s documentation. (#530)

* (DOCSP-45558) Add section to FAQ page.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Procedure.

* (DOCSP-45558) Edit formatting.

* (DOCSP-45558) Edits.

* (DOCSP-45558) edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Add pause step to FAQ and edit FAQ link.

* (DOCSP-45558) Add update section to configuration page.

* (DOCSP-45558) Standardize link to update documentation.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Normalize links.

* (DOCSP-45558) Edit introduction to Optionsgst
q

* (DOCSP-45558) Edit Settings introduction.

* (DOCSP-45558) Updates.

* (DOCSP-45558) Make consistent intros to command line opts vs config file settings.

* (DOCSP-45558) Edit wording.

* (DOCSP-45558) Shorten sentence.

* (DOCSP-45558) updates.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edit important admonition.

* (DOCSP-45558) @jwilson-mdb Review changes.

* (DOCSP-45558) Add command line options to configuration intro.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) @FGasper Review changes.

(cherry picked from commit ccd72ea)

* (DOCSP-45558) Fix typo.
sarah-olson-mongodb pushed a commit that referenced this pull request Jan 14, 2025
…sync’s-documentation-v1.9-backport (530) (#546)

* (DOCSP-45558) [C2C] Mention altering load level during a migration in mongosync’s documentation. (#530)

* (DOCSP-45558) Add section to FAQ page.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Procedure.

* (DOCSP-45558) Edit formatting.

* (DOCSP-45558) Edits.

* (DOCSP-45558) edits.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Add pause step to FAQ and edit FAQ link.

* (DOCSP-45558) Add update section to configuration page.

* (DOCSP-45558) Standardize link to update documentation.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Normalize links.

* (DOCSP-45558) Edit introduction to Optionsgst
q

* (DOCSP-45558) Edit Settings introduction.

* (DOCSP-45558) Updates.

* (DOCSP-45558) Make consistent intros to command line opts vs config file settings.

* (DOCSP-45558) Edit wording.

* (DOCSP-45558) Shorten sentence.

* (DOCSP-45558) updates.

* (DOCSP-45558) Edits.

* (DOCSP-45558) Edit.

* (DOCSP-45558) Edit important admonition.

* (DOCSP-45558) @jwilson-mdb Review changes.

* (DOCSP-45558) Add command line options to configuration intro.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) Fix subtitle underline.

* (DOCSP-45558) @FGasper Review changes.

(cherry picked from commit ccd72ea)

* (DOCSP-45558) Fix typo.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants