-
Notifications
You must be signed in to change notification settings - Fork 39
(DOCSP-45558)-Mention-altering-load-level-during-a-migration-in-mongosync’s-documentation #530
(DOCSP-45558)-Mention-altering-load-level-during-a-migration-in-mongosync’s-documentation #530
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ded05a2
to
a828c63
Compare
294fa28
to
c93dc3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this came out great!! The configuration page looks to be a good home for reconfiguring, and the crosslinking seems pretty intuitive to me. Nice job.
I left a couple of small suggestions for you to review/update before requesting an ext review, but overall LGTM!
source/reference/configuration.txt
Outdated
using a configuration file. The configuration file contains settings that are | ||
the equivalent of ``mongosync`` command line options. | ||
|
||
During a migration, you can reconfigure certain ``mongosync`` options by following the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Consistency/clarity]
I realize that the current content uses both "settings" and "options" (from command line options), but i think it may be best to stick with "settings" on this page for consistency.
During a migration, you can reconfigure certain ``mongosync`` options by following the | |
During a migration, you can reconfigure certain ``mongosync`` settings by following the |
source/reference/configuration.txt
Outdated
Settings | ||
~~~~~~~~ | ||
|
||
The following settings can be set from a configuration file to configure ``mongosync`` at startup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Active Voice]
Rephrase to eliminate passive voice ("can be set") style guide
The following settings can be set from a configuration file to configure ``mongosync`` at startup. | |
You can configure the following ``mongosync`` settings at startup by using a configuration file. |
source/reference/configuration.txt
Outdated
|
||
Options | ||
======= | ||
To set these settings from the command line, see :ref:`c2c-cli-options`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional / nit]
Optional rephrasing to avoid the set/setting repetition
To set these settings from the command line, see :ref:`c2c-cli-options`. | |
To configure ``mongosync`` from the command line, see :ref:`c2c-cli-options`. |
source/reference/configuration.txt
Outdated
--cluster1 "<cluster1_connection_string>" \ | ||
--loadLevel <newLevel> | ||
|
||
To learn more, see :ref:`Initialize mongosync <c2c-initialize>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit / optional 😄 ]
Nothing wrong with "To learn more", but I think we tend to lean towards "For more information" in the server docs.
source/reference/mongosync.txt
Outdated
|
||
.. include:: /includes/opts/disableTelemetry | ||
|
||
To disable telemetry data collection during a migration, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question / optional]
Would it make more sense to change the order slightly here and put the configuration file link before the link to reconfigure during a migration?
Maybe an SME can chime in, but my initial thought is someone viewing this page may find the configuration file link more relevant/useful than the reconfiguration instructions.
I'm not too sure how often someone might need to reconfigure so this is a weakly held opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going back and forth with the ordering, so I appreciate the feedback. I agree with your reasoning here, so I moved the reconfig link below the config file link!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall. I have a couple small-ish points; see what you think.
source/reference/configuration.txt
Outdated
|
||
.. important:: | ||
|
||
You can't adjust the :setting:`cluster0`, :setting:`cluster1`, or :setting:`id` settings during a migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this list going to need further updates as further settings are added?
Something like this might be more maintainable:
Only the following settings are adjustable during a migration. Others MUST remain unchanged between
mongosync
restarts.
.. procedure:: | ||
:style: normal | ||
|
||
.. step:: (Optional) Pause the ``mongosync`` processes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit of doing this versus just terminating the mongosync processes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tip in this step (borrowed from the mongosync Live Upgrade tutorial) describes a reason why users might want to pause before terminating:
If you don't want to immediately resume data synchronization operations after live upgrade, consider pausing the
mongosync
processes. This is useful if you're coordinating operations from multiplemongosync
processes.
Please let me know if you think this tip is not true or helpful! If that's the case, then I can remove this step and update the final step.
… mongosync’s documentation. (mongodb#530) * (DOCSP-45558) Add section to FAQ page. * (DOCSP-45558) Edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Procedure. * (DOCSP-45558) Edit formatting. * (DOCSP-45558) Edits. * (DOCSP-45558) edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Add pause step to FAQ and edit FAQ link. * (DOCSP-45558) Add update section to configuration page. * (DOCSP-45558) Standardize link to update documentation. * (DOCSP-45558) Edit. * (DOCSP-45558) Edits. * (DOCSP-45558) Normalize links. * (DOCSP-45558) Edit introduction to Optionsgst q * (DOCSP-45558) Edit Settings introduction. * (DOCSP-45558) Updates. * (DOCSP-45558) Make consistent intros to command line opts vs config file settings. * (DOCSP-45558) Edit wording. * (DOCSP-45558) Shorten sentence. * (DOCSP-45558) updates. * (DOCSP-45558) Edits. * (DOCSP-45558) Edit. * (DOCSP-45558) Edit important admonition. * (DOCSP-45558) @jwilson-mdb Review changes. * (DOCSP-45558) Add command line options to configuration intro. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) @FGasper Review changes. (cherry picked from commit ccd72ea)
… mongosync’s documentation. (mongodb#530) * (DOCSP-45558) Add section to FAQ page. * (DOCSP-45558) Edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Procedure. * (DOCSP-45558) Edit formatting. * (DOCSP-45558) Edits. * (DOCSP-45558) edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Add pause step to FAQ and edit FAQ link. * (DOCSP-45558) Add update section to configuration page. * (DOCSP-45558) Standardize link to update documentation. * (DOCSP-45558) Edit. * (DOCSP-45558) Edits. * (DOCSP-45558) Normalize links. * (DOCSP-45558) Edit introduction to Optionsgst q * (DOCSP-45558) Edit Settings introduction. * (DOCSP-45558) Updates. * (DOCSP-45558) Make consistent intros to command line opts vs config file settings. * (DOCSP-45558) Edit wording. * (DOCSP-45558) Shorten sentence. * (DOCSP-45558) updates. * (DOCSP-45558) Edits. * (DOCSP-45558) Edit. * (DOCSP-45558) Edit important admonition. * (DOCSP-45558) @jwilson-mdb Review changes. * (DOCSP-45558) Add command line options to configuration intro. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) @FGasper Review changes. (cherry picked from commit ccd72ea)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…sync’s-documentation-v1.8-backport (530) (#547) * (DOCSP-45558) [C2C] Mention altering load level during a migration in mongosync’s documentation. (#530) * (DOCSP-45558) Add section to FAQ page. * (DOCSP-45558) Edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Procedure. * (DOCSP-45558) Edit formatting. * (DOCSP-45558) Edits. * (DOCSP-45558) edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Add pause step to FAQ and edit FAQ link. * (DOCSP-45558) Add update section to configuration page. * (DOCSP-45558) Standardize link to update documentation. * (DOCSP-45558) Edit. * (DOCSP-45558) Edits. * (DOCSP-45558) Normalize links. * (DOCSP-45558) Edit introduction to Optionsgst q * (DOCSP-45558) Edit Settings introduction. * (DOCSP-45558) Updates. * (DOCSP-45558) Make consistent intros to command line opts vs config file settings. * (DOCSP-45558) Edit wording. * (DOCSP-45558) Shorten sentence. * (DOCSP-45558) updates. * (DOCSP-45558) Edits. * (DOCSP-45558) Edit. * (DOCSP-45558) Edit important admonition. * (DOCSP-45558) @jwilson-mdb Review changes. * (DOCSP-45558) Add command line options to configuration intro. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) @FGasper Review changes. (cherry picked from commit ccd72ea) * (DOCSP-45558) Fix typo.
…sync’s-documentation-v1.9-backport (530) (#546) * (DOCSP-45558) [C2C] Mention altering load level during a migration in mongosync’s documentation. (#530) * (DOCSP-45558) Add section to FAQ page. * (DOCSP-45558) Edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Procedure. * (DOCSP-45558) Edit formatting. * (DOCSP-45558) Edits. * (DOCSP-45558) edits. * (DOCSP-45558) Edits. * (DOCSP-45558) Add pause step to FAQ and edit FAQ link. * (DOCSP-45558) Add update section to configuration page. * (DOCSP-45558) Standardize link to update documentation. * (DOCSP-45558) Edit. * (DOCSP-45558) Edits. * (DOCSP-45558) Normalize links. * (DOCSP-45558) Edit introduction to Optionsgst q * (DOCSP-45558) Edit Settings introduction. * (DOCSP-45558) Updates. * (DOCSP-45558) Make consistent intros to command line opts vs config file settings. * (DOCSP-45558) Edit wording. * (DOCSP-45558) Shorten sentence. * (DOCSP-45558) updates. * (DOCSP-45558) Edits. * (DOCSP-45558) Edit. * (DOCSP-45558) Edit important admonition. * (DOCSP-45558) @jwilson-mdb Review changes. * (DOCSP-45558) Add command line options to configuration intro. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) Fix subtitle underline. * (DOCSP-45558) @FGasper Review changes. (cherry picked from commit ccd72ea) * (DOCSP-45558) Fix typo.
DESCRIPTION
Per this Slack thread, mongosync’s docs should specifically address mid-migration load level adjustments.
Suggested text:
STAGING
Configuration
mongosync
FAQ
JIRA
DOCSP-45558
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?