-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-45965: Embedded Verifier: Verify Reversible Migrations #549
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @elyse-mdb. Left a comment for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mayaraman19, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion! Also tagging @mvankeulen94 for input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! a few comments from my end
- :authrole:`clusterMonitor` | ||
- :authrole:`dbAdminAnyDatabase` | ||
- :authrole:`readWriteAnyDatabase` | ||
- :authrole:`restore` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it's a staging-specific issue but I see different formatting for the Self-Managed Clusters permissions vs the Atlas Clusters permissions. will the formatting be the same for the published link?
- atlasAdmin | ||
|
||
* - write-blocking or reversing | ||
* - write-blocking or reversing (including multiple reversals) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for readability, I'd suggest replacing "write-blocking or reversing (including multiple reversals)" with "Write-blocking / Reversing / Multiple Reversals" since we differentiate between Reversing and Multiple Reversals as two separate sync types in the Self-managed Clusters section.
https://jira.mongodb.org/browse/DOCSP-45965
Remove limitations on verifier not being enabled for reverse direction of reversible migration. Also adds permissions info.
Staging: