Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit fd5a10f
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67897c94aab76d0008622534
😎 Deploy Preview https://deploy-preview-549--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @elyse-mdb. Left a comment for your consideration.

Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mayaraman19, LGTM!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion! Also tagging @mvankeulen94 for input

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! a few comments from my end

- :authrole:`clusterMonitor`
- :authrole:`dbAdminAnyDatabase`
- :authrole:`readWriteAnyDatabase`
- :authrole:`restore`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it's a staging-specific issue but I see different formatting for the Self-Managed Clusters permissions vs the Atlas Clusters permissions. will the formatting be the same for the published link?

- atlasAdmin

* - write-blocking or reversing
* - write-blocking or reversing (including multiple reversals)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for readability, I'd suggest replacing "write-blocking or reversing (including multiple reversals)" with "Write-blocking / Reversing / Multiple Reversals" since we differentiate between Reversing and Multiple Reversals as two separate sync types in the Self-managed Clusters section.

@jmd-mongo jmd-mongo merged commit d50b57d into mongodb:master Jan 27, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants