This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-46629-replSetResizeOplog-unsupported-Atlas #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ltran-mdb2
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Thanks for this work @amalhotra-mdb ! I just left a small question/suggestion
source/reference/oplog-sizing.txt
Outdated
Comment on lines
67
to
70
| .. note:: | ||
|
|
||
| :dbcommand:`replSetResizeOplog` is unsupported in Atlas. To resize | ||
| the oplog in Atlas, see :ref:`set-oplog-size`. |
There was a problem hiding this comment.
[question/suggestion] Since this note pertains specifically to the above bullet, should it be indented under the bullet (as opposed to in line with the bullet)?
Suggested change
| .. note:: | |
| :dbcommand:`replSetResizeOplog` is unsupported in Atlas. To resize | |
| the oplog in Atlas, see :ref:`set-oplog-size`. | |
| .. note:: | |
| :dbcommand:`replSetResizeOplog` is unsupported in Atlas. To resize | |
| the oplog in Atlas, see :ref:`set-oplog-size`. |
There was a problem hiding this comment.
This makes sense @ltran-mdb2 ! Thanks for this suggestion, fixed!
ltran-mdb2
approved these changes
Jan 22, 2025
JuliaMongo
approved these changes
Jan 22, 2025
| to set ``minRetentionHours`` greater than the current ``oplog`` | ||
| window. | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
Do c2c docs use a replacement for Atlas, like |service|? If so, use it here too. If not, then leave Atlas.
There was a problem hiding this comment.
Please review with the dev team as well, cc Ankit Luthra (via slack).
ermay12
approved these changes
Jan 23, 2025
rohshar
approved these changes
Jan 28, 2025
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Jan 29, 2025
* DOCSP-46629-replSetResizeOplog-unsupported-Atlas * indent * reviewer changes * undo some changes (cherry picked from commit 1175079)
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Jan 29, 2025
* DOCSP-46629-replSetResizeOplog-unsupported-Atlas * indent * reviewer changes * undo some changes (cherry picked from commit 1175079)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Jan 29, 2025
* DOCSP-46629-replSetResizeOplog-unsupported-Atlas * indent * reviewer changes * undo some changes (cherry picked from commit 1175079)
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Jan 29, 2025
* DOCSP-46629-replSetResizeOplog-unsupported-Atlas * indent * reviewer changes * undo some changes (cherry picked from commit 1175079)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jmd-mongo
pushed a commit
that referenced
this pull request
Jan 29, 2025
jmd-mongo
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Update the oplog sizing page to indicate that replSetResizeOplog is incompatible in Atlas. Add a note that redirects the user to the Atlas page for resizing their oplog.
STAGING
https://deploy-preview-558--docs-cluster-to-cluster-sync.netlify.app/reference/oplog-sizing/#validate-oplog-size
JIRA
https://jira.mongodb.org/browse/DOCSP-46629
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?