Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Jan 27, 2025

DESCRIPTION

fixes typo on finalize cutover page

STAGING

https://deploy-preview-568--docs-cluster-to-cluster-sync.netlify.app/reference/cutover-process/#verify-the-status-of-mongosync.

JIRA

https://jira.mongodb.org/browse/DOCSP-46814

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit f7bfe42
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/679a6cc1ea43780007076142
😎 Deploy Preview https://deploy-preview-568--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one clarification question!

If ``/commit`` is called and the values are not near
``0`` or if the verifier is not in the stream hashing
phase, the cutover process might take a long a time.
If you call ``/commit`` and the ``lagTimeSeconds`` fields are
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I know this is a bit out of scope for this typo PR

Just for clarification, is this condition saying that the cutover process might take a long time either if:

  • You call /commit and and the lagTimeSeconds fields are not near 0
  • You call /commit and the verifier is not in the stream hashing phase

OR

Is it saying that the cutover process might take a long time either if:

  • You call /commit and and the lagTimeSeconds fields are not near 0
  • The verifier is not in the stream hashing phase

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first option. the cutover process requires /commit to be called

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clarification @ajhuh-mdb and @ajayvijayakumar123 ! I removed the mention of /commit in this sentence to avoid redundancy and improve clarity.

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltran-mdb2 ltran-mdb2 merged commit ce4e39e into mongodb:master Jan 29, 2025
4 checks passed
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Feb 5, 2025
* DOCSP-46814-finalize-cutover-typo

* DOCSP-46814 copy edit

* DOCSP-46814 copy edit

(cherry picked from commit ce4e39e)
@ltran-mdb2
Copy link
Collaborator Author

💔 Some backports could not be created

Status Branch Result
v1.10 Cherrypick failed because the selected commit (ce4e39e) is empty. Did you already backport this commit?
v1.9
v1.8 Could not create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between mongodb:v1.8 and ltran-mdb2:DOCSP-46814-finalize-cutover-typo-v1.8-backport"}

Manual backport

To create the backport manually run:

backport --pr 568

Questions ?

Please refer to the Backport tool documentation

ltran-mdb2 added a commit that referenced this pull request Feb 5, 2025
* DOCSP-46814-finalize-cutover-typo

* DOCSP-46814 copy edit

* DOCSP-46814 copy edit

(cherry picked from commit ce4e39e)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants