This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-46038-1.9.0-verification #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajayvijayakumar123
suggested changes
Jan 31, 2025
| @@ -0,0 +1 @@ | |||
| If you live upgrade from any version before 1.9.0 to 1.9.0, ``mongosync`` disables embedded verification. No newline at end of file | |||
There was a problem hiding this comment.
Suggested change
| If you live upgrade from any version before 1.9.0 to 1.9.0, ``mongosync`` disables embedded verification. | |
| If you live upgrade from any version before 1.9.0, ``mongosync`` disables embedded verification. |
There was a problem hiding this comment.
If you live upgrade from pre-1.9.0 --> 1.9.0+ (so 1.9.0 or 1.10) then verification will be disabled. I think this suggestion makes the limitation a bit more general
Thanks for your review, @ajayvijayakumar123 ! I added your suggestion – i wasn't sure if you wanted any other changes in the wording re: the comment you made after your suggestion, so lmk how the change looks to you. Thanks! |
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Feb 3, 2025
* DOCSP-46038-1.9.0-verification * fix include render * fix file name * reviewer changes * rewording * reviewer changes (cherry picked from commit 6160c2c)
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Feb 3, 2025
* DOCSP-46038-1.9.0-verification * fix include render * fix file name * reviewer changes * rewording * reviewer changes (cherry picked from commit 6160c2c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jmd-mongo
pushed a commit
that referenced
this pull request
Feb 3, 2025
jmd-mongo
pushed a commit
that referenced
this pull request
Feb 3, 2025
jwilson-mdb
pushed a commit
to jwilson-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Feb 5, 2025
* DOCSP-46038-1.9.0-verification * fix include render * fix file name * reviewer changes * rewording * reviewer changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Add limitation that mongosync disables embedded verification only when upgrading to 1.9.0 from any pre-1.9.0 version to limitations page and 1.9 release notes.
STAGING
https://deploy-preview-578--docs-cluster-to-cluster-sync.netlify.app/reference/limitations/#embedded-verifier
https://deploy-preview-578--docs-cluster-to-cluster-sync.netlify.app/release-notes/1.9/
JIRA
https://jira.mongodb.org/browse/DOCSP-46038
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?