-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-46854-migrate-pqs-tutorial #580
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/reference/c2c-migrate-pqs.txt
Outdated
|
||
If your source cluster contains query settings that you do not want to | ||
migrate to your destination cluster, remove those settings from your | ||
``querySettings`` array. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Should a command or further explanation of remove be given here, or will the user find this intuitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are numerous ways a user could do this depending on their use case but will check with the tech reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You folks probably know the target audience’s level of technical expertise better than I, but I would think removal of an element from a JSON array to be feasible for such users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve left a few notes.
I’m withholding technical approval pending a check from Denis Grebennicov, who knows PQS intimately from the server side.
source/reference/c2c-migrate-pqs.txt
Outdated
If your source cluster uses Persistent Query Settings (PQS), you must manually | ||
migrate those settings to your destination cluster to finalize sync. | ||
|
||
``mongosync`` checks for PQS during the :ref:`cutover process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It also checks during initialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
source/reference/c2c-migrate-pqs.txt
Outdated
|
||
If your source cluster contains query settings that you do not want to | ||
migrate to your destination cluster, remove those settings from your | ||
``querySettings`` array. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You folks probably know the target audience’s level of technical expertise better than I, but I would think removal of an element from a JSON array to be feasible for such users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Denis Grebennicov should also review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this @ltran-mdb2!
LGTM with some minor comments
source/reference/c2c-migrate-pqs.txt
Outdated
Steps ----- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steps ----- | |
Steps | |
----- |
[nit] I think -----
should be on the newline, as it was rendering correctly in the browser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
source/reference/c2c-migrate-pqs.txt
Outdated
Run the following code block to export your query settings into an array | ||
called ``querySettings``: | ||
|
||
.. code-block:: shell | ||
|
||
mongosh --eval | ||
'console.log(db.aggregate([{$querySettings:{}}]).toArray())' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[note] will this export query settings into an array? Or will this just print/log all currently set query settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is a good point … @ltran-mdb2 how is the array named querySettings
?
When I ran it, it just outputted an array; there’s no name to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I misinterpreted the JIRA of this ticket. I updated the steps accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
* DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854 tech edits * DOCSP-46854 tech edits * DOCSP-46854 fixing build (cherry picked from commit 9da7e4e) # Conflicts: # source/reference/cutover-process.txt
* DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854 tech edits * DOCSP-46854 tech edits * DOCSP-46854 fixing build (cherry picked from commit 9da7e4e) # Conflicts: # source/reference/cutover-process.txt
* DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854 tech edits * DOCSP-46854 tech edits * DOCSP-46854 fixing build (cherry picked from commit 9da7e4e) # Conflicts: # source/reference/cutover-process.txt
💔 Some backports could not be created
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
* DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854 tech edits * DOCSP-46854 tech edits * DOCSP-46854 fixing build (cherry picked from commit 9da7e4e) # Conflicts: # source/reference/cutover-process.txt
* DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854 tech edits * DOCSP-46854 tech edits * DOCSP-46854 fixing build (cherry picked from commit 9da7e4e) # Conflicts: # source/reference/cutover-process.txt
* DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854-migrate-pqs-tutorial * DOCSP-46854 tech edits * DOCSP-46854 tech edits * DOCSP-46854 fixing build (cherry picked from commit 9da7e4e) # Conflicts: # source/reference/cutover-process.txt
DESCRIPTION
Tutorial for manually migration persistent query settings
STAGING
https://deploy-preview-580--docs-cluster-to-cluster-sync.netlify.app/reference/c2c-migrate-pqs/
https://deploy-preview-580--docs-cluster-to-cluster-sync.netlify.app/reference/cutover-process/#send-a-commit-request-to-mongosync.
JIRA
https://jira.mongodb.org/browse/DOCSP-46854
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?