Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Feb 3, 2025

DESCRIPTION

Tutorial for manually migration persistent query settings

STAGING

https://deploy-preview-580--docs-cluster-to-cluster-sync.netlify.app/reference/c2c-migrate-pqs/
https://deploy-preview-580--docs-cluster-to-cluster-sync.netlify.app/reference/cutover-process/#send-a-commit-request-to-mongosync.

JIRA

https://jira.mongodb.org/browse/DOCSP-46854

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 7e9c326
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67a5012798f6740008ceee6f
😎 Deploy Preview https://deploy-preview-580--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 36 to 40

If your source cluster contains query settings that you do not want to
migrate to your destination cluster, remove those settings from your
``querySettings`` array.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Should a command or further explanation of remove be given here, or will the user find this intuitive?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are numerous ways a user could do this depending on their use case but will check with the tech reviewer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You folks probably know the target audience’s level of technical expertise better than I, but I would think removal of an element from a JSON array to be feasible for such users.

Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve left a few notes.

I’m withholding technical approval pending a check from Denis Grebennicov, who knows PQS intimately from the server side.

If your source cluster uses Persistent Query Settings (PQS), you must manually
migrate those settings to your destination cluster to finalize sync.

``mongosync`` checks for PQS during the :ref:`cutover process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It also checks during initialization.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Comment on lines 36 to 40

If your source cluster contains query settings that you do not want to
migrate to your destination cluster, remove those settings from your
``querySettings`` array.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You folks probably know the target audience’s level of technical expertise better than I, but I would think removal of an element from a JSON array to be feasible for such users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denis Grebennicov should also review this.

Copy link
Member

@denis631 denis631 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @ltran-mdb2!

LGTM with some minor comments

Comment on lines 20 to 21
Steps -----

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Steps -----
Steps
-----

[nit] I think ----- should be on the newline, as it was rendering correctly in the browser?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Comment on lines 27 to 33
Run the following code block to export your query settings into an array
called ``querySettings``:

.. code-block:: shell

mongosh --eval
'console.log(db.aggregate([{$querySettings:{}}]).toArray())'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] will this export query settings into an array? Or will this just print/log all currently set query settings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is a good point … @ltran-mdb2 how is the array named querySettings?

When I ran it, it just outputted an array; there’s no name to it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I misinterpreted the JIRA of this ticket. I updated the steps accordingly.

@ltran-mdb2 ltran-mdb2 requested a review from FGasper February 5, 2025 21:07
Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ltran-mdb2 ltran-mdb2 merged commit 9da7e4e into mongodb:master Feb 6, 2025
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Feb 6, 2025
* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854 tech edits

* DOCSP-46854 tech edits

* DOCSP-46854 fixing build

(cherry picked from commit 9da7e4e)

# Conflicts:
#	source/reference/cutover-process.txt
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Feb 6, 2025
* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854 tech edits

* DOCSP-46854 tech edits

* DOCSP-46854 fixing build

(cherry picked from commit 9da7e4e)

# Conflicts:
#	source/reference/cutover-process.txt
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Feb 6, 2025
* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854 tech edits

* DOCSP-46854 tech edits

* DOCSP-46854 fixing build

(cherry picked from commit 9da7e4e)

# Conflicts:
#	source/reference/cutover-process.txt
@ltran-mdb2
Copy link
Collaborator Author

💔 Some backports could not be created

Status Branch Result
v1.11 The branch "v1.11" does not exist
v1.10
v1.9
v1.8

Manual backport

To create the backport manually run:

backport --pr 580

Questions ?

Please refer to the Backport tool documentation

ltran-mdb2 added a commit that referenced this pull request Feb 6, 2025
* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854 tech edits

* DOCSP-46854 tech edits

* DOCSP-46854 fixing build

(cherry picked from commit 9da7e4e)

# Conflicts:
#	source/reference/cutover-process.txt
ltran-mdb2 added a commit that referenced this pull request Feb 6, 2025
* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854 tech edits

* DOCSP-46854 tech edits

* DOCSP-46854 fixing build

(cherry picked from commit 9da7e4e)

# Conflicts:
#	source/reference/cutover-process.txt
ltran-mdb2 added a commit that referenced this pull request Feb 6, 2025
* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854-migrate-pqs-tutorial

* DOCSP-46854 tech edits

* DOCSP-46854 tech edits

* DOCSP-46854 fixing build

(cherry picked from commit 9da7e4e)

# Conflicts:
#	source/reference/cutover-process.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants