DOCSP-20362 Update links for subdomain consolidation project #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mdb-ashley
commented
Mar 28, 2022
mdb-ashley
commented
- Ticket: https://jira.mongodb.org/browse/DOCSP-20362
schmalliso
reviewed
Mar 28, 2022
|
Wrong PR. Oops. |
There was a problem hiding this comment.
Thanks @mdb-ashley ! I have a few suggestions here but the main theme is preferring roles when possible. Let me know if you have any questions!
source/bsondump.txt
Outdated
Comment on lines
47
to
49
| - `MongoDB 4.2 bsondump <https://www.mongodb.com/docs/v4.2/reference/program/bsondump>`__ | ||
| - `MongoDB 4.0 bsondump <https://www.mongodb.com/docs/v4.0/reference/program/bsondump>`__ | ||
| - `MongoDB 3.6 bsondump <https://www.mongodb.com/docs/v3.6/reference/program/bsondump>`__ |
There was a problem hiding this comment.
For these, rather than using full URLs, I think using the version roles may be better.
Suggested change
| - `MongoDB 4.2 bsondump <https://www.mongodb.com/docs/v4.2/reference/program/bsondump>`__ | |
| - `MongoDB 4.0 bsondump <https://www.mongodb.com/docs/v4.0/reference/program/bsondump>`__ | |
| - `MongoDB 3.6 bsondump <https://www.mongodb.com/docs/v3.6/reference/program/bsondump>`__ | |
| - :v4.2:`MongoDB 4.2 bsondump </reference/program/bsondump>` | |
| - :v4.0:`MongoDB 4.0 bsondump </reference/program/bsondump>` |
I think we can remove the v3.6 link because it's EOL.
This comment applies to the other db tools pages edited as part of this PR.
| - `MongoDB 4.2 Tools <https://docs.mongodb.com/v4.2/reference/program/>`__ | ||
| - `MongoDB 4.0 Tools <https://docs.mongodb.com/v4.0/reference/program/>`__ | ||
| - `MongoDB 3.6 Tools <https://docs.mongodb.com/v3.6/reference/program/>`__ | ||
| - `MongoDB 4.2 Tools <https://www.mongodb.com/docs/v4.2/reference/program/>`__ |
There was a problem hiding this comment.
See comment on bsondump.
source/index.txt
Outdated
| @@ -109,13 +109,13 @@ Further Reading | |||
| `MongoDB, Inc.`_ | |||
| The company behind MongoDB. | |||
|
|
|||
| `MongoDB Manual <https://docs.mongodb.com/manual?tck=docs_databasetools>`__ | |||
| `MongoDB Manual <https://www.mongodb.com/docs/manual/?tck=docs_databasetools>`__ | |||
There was a problem hiding this comment.
We can use the :manual: role here:
Suggested change
| `MongoDB Manual <https://www.mongodb.com/docs/manual/?tck=docs_databasetools>`__ | |
| :manual:`MongoDB Manual </?tck=docs_databasetools>` |
source/index.txt
Outdated
| The MongoDB server documentation. | ||
|
|
||
| `MongoDB Atlas <https://www.mongodb.com/cloud?tck=docs_databasetools>`__ | ||
| Database as a service. | ||
|
|
||
| `MongoDB Ecosystem <https://docs.mongodb.com/ecosystem/?tck=docs_databasetools>`__ | ||
| `MongoDB Ecosystem <https://www.mongodb.com/docs/drivers/?tck=docs_databasetools>`__ |
There was a problem hiding this comment.
We can use the :ecosystem: role here:
Suggested change
| `MongoDB Ecosystem <https://www.mongodb.com/docs/drivers/?tck=docs_databasetools>`__ | |
| :ecosystem:`MongoDB Ecosystem </?tck=docs_databasetools>` |
source/mongodump.txt
Outdated
| - `MongoDB 4.2 mongodump <https://docs.mongodb.com/v4.2/reference/program/mongodump>`__ | ||
| - `MongoDB 4.0 mongodump <https://docs.mongodb.com/v4.0/reference/program/mongodump>`__ | ||
| - `MongoDB 3.6 mongodump <https://docs.mongodb.com/v3.6/reference/program/mongodump>`__ | ||
| - `MongoDB 4.2 mongodump <https://www.mongodb.com/docs/v4.2/reference/program/mongodump>`__ |
There was a problem hiding this comment.
See comment on bsondump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.