-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-43838 - Upgrade Guides #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple clarifying questions
source/upgrade/v3.txt
Outdated
|
||
#. If you're using a 2.x version of the {+driver-short+}, upgrade to | ||
v{+last-version-2-number+}. To do so, follow the | ||
:ref:`v2.x upgrade guide <csharp-upgrade-v2>` guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:ref:`v2.x upgrade guide <csharp-upgrade-v2>` guide. | |
:ref:`v2.x upgrade guide <csharp-upgrade-v2>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
source/upgrade/v3.txt
Outdated
#. Address any breaking changes between the driver version your | ||
application uses and your target upgrade version in the | ||
:ref:`Breaking Changes by Version <csharp-breaking-changes-v3>` section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Since they have to upgrade to v2.9 first, wouldn't this step just be to address the changes listed below? Judging by the Slack thread w/ Rishit, it seemed to me like we will only be showing 3.0 and no minor versions on this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. i didn't think to change that after rishit suggested updating the page title
source/upgrade/v3.txt
Outdated
The following sections describe the potential breaking changes introduced by each driver | ||
version. If a driver version is not included in this section, it doesn't introduce any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar Q/S here. If this page will only have 3.0, we can simplify this to state that rather than saying "introduced by each driver version"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions but otherwise LGTM!
Co-authored-by: Jordan Smith <45415425+jordan-smith721@users.noreply.github.com>
Co-authored-by: Jordan Smith <45415425+jordan-smith721@users.noreply.github.com>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43838
Staging Links
Self-Review Checklist