Skip to content

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Sep 25, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43838

Staging Links

  • upgrade/v2
  • upgrade/v3
  • upgrade
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Sep 25, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit d5395b2
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66f58f45903ce20008741239
    😎 Deploy Preview https://deploy-preview-239--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just a couple clarifying questions


    #. If you're using a 2.x version of the {+driver-short+}, upgrade to
    v{+last-version-2-number+}. To do so, follow the
    :ref:`v2.x upgrade guide <csharp-upgrade-v2>` guide.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    :ref:`v2.x upgrade guide <csharp-upgrade-v2>` guide.
    :ref:`v2.x upgrade guide <csharp-upgrade-v2>`.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good catch

    Comment on lines 40 to 42
    #. Address any breaking changes between the driver version your
    application uses and your target upgrade version in the
    :ref:`Breaking Changes by Version <csharp-breaking-changes-v3>` section.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Q: Since they have to upgrade to v2.9 first, wouldn't this step just be to address the changes listed below? Judging by the Slack thread w/ Rishit, it seemed to me like we will only be showing 3.0 and no minor versions on this page?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good point. i didn't think to change that after rishit suggested updating the page title

    Comment on lines 55 to 56
    The following sections describe the potential breaking changes introduced by each driver
    version. If a driver version is not included in this section, it doesn't introduce any
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Similar Q/S here. If this page will only have 3.0, we can simplify this to state that rather than saying "introduced by each driver version"

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Two suggestions but otherwise LGTM!

    Co-authored-by: Jordan Smith <45415425+jordan-smith721@users.noreply.github.com>
    @mongoKart mongoKart merged commit 1d62b60 into mongodb:v3.0 Sep 26, 2024
    4 of 6 checks passed
    @mongoKart mongoKart deleted the docsp-43838-upgrade-guide branch September 26, 2024 16:44
    mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Co-authored-by: Jordan Smith <45415425+jordan-smith721@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants