Skip to content

DOCSP-49585: v5.2 release #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented May 21, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49585

Staging Links

  • compatibility
  • connect
  • interact-data/crud
  • limitations-upcoming
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented May 21, 2025

    Deploy Preview for docs-django ready!

    Name Link
    🔨 Latest commit c443dd5
    🔍 Latest deploy log https://app.netlify.com/projects/docs-django/deploys/682f31f5381df500088cbf85
    😎 Deploy Preview https://deploy-preview-34--docs-django.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link
    Collaborator

    @timgraham timgraham left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    There's a hardcoded version number in a URL:

    source/interact-data/crud.txt:more information, see the `Django Admin Site <https://docs.djangoproject.com/en/5.1/ref/contrib/admin/>`__
    

    @@ -10,7 +10,7 @@
    - Python 3.10
    - Python 3.9

    * - 5.1
    * - 5.1 to 5.2
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'd suggest including them on separate lines. When Python 3.14 comes out soon, it'll likely only be supported on 5.2.

    Also, with the release of Django 5.2, Django 5.0 is end of life, so we could remove that line in the 5.2 docs.

    For example, {+django-odm+} version 5.1 requires Django 5.1. The minimum supported
    Django version is 5.0.
    For example, {+django-odm+} version {+django-version+} requires Django {+django-version+}.
    The minimum supported Django version is 5.0.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It might be best to remove this sentence since Django 5.0 is now end-of-life and unsupported.

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    If you end up removing the 5.0, this might not be relevant, but you shouldn't combine the variables with a hardcoded value because this will become out of date once v6.0 is released. Since this is an example, you can just use hardcoded versions for all of these.

    Copy link
    Collaborator Author

    @norareidy norareidy May 22, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I removed that line about the minimum supported Django verison. Not sure which variable I would use instead, since the minimum supported version is not the {+django-version+} (right now it's 5.1).

    Copy link
    Collaborator

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    One comment:

    For example, {+django-odm+} version 5.1 requires Django 5.1. The minimum supported
    Django version is 5.0.
    For example, {+django-odm+} version {+django-version+} requires Django {+django-version+}.
    The minimum supported Django version is 5.0.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    If you end up removing the 5.0, this might not be relevant, but you shouldn't combine the variables with a hardcoded value because this will become out of date once v6.0 is released. Since this is an example, you can just use hardcoded versions for all of these.

    @norareidy norareidy merged commit bd36022 into mongodb:master May 22, 2025
    5 checks passed
    @norareidy norareidy deleted the DOCSP-49585-v5.2 branch May 22, 2025 14:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants