-
Notifications
You must be signed in to change notification settings - Fork 7
DOCSP-49585: v5.2 release #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-django ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a hardcoded version number in a URL:
source/interact-data/crud.txt:more information, see the `Django Admin Site <https://docs.djangoproject.com/en/5.1/ref/contrib/admin/>`__
@@ -10,7 +10,7 @@ | |||
- Python 3.10 | |||
- Python 3.9 | |||
|
|||
* - 5.1 | |||
* - 5.1 to 5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest including them on separate lines. When Python 3.14 comes out soon, it'll likely only be supported on 5.2.
Also, with the release of Django 5.2, Django 5.0 is end of life, so we could remove that line in the 5.2 docs.
source/compatibility.txt
Outdated
For example, {+django-odm+} version 5.1 requires Django 5.1. The minimum supported | ||
Django version is 5.0. | ||
For example, {+django-odm+} version {+django-version+} requires Django {+django-version+}. | ||
The minimum supported Django version is 5.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be best to remove this sentence since Django 5.0 is now end-of-life and unsupported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you end up removing the 5.0
, this might not be relevant, but you shouldn't combine the variables with a hardcoded value because this will become out of date once v6.0 is released. Since this is an example, you can just use hardcoded versions for all of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed that line about the minimum supported Django verison. Not sure which variable I would use instead, since the minimum supported version is not the {+django-version+} (right now it's 5.1).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment:
source/compatibility.txt
Outdated
For example, {+django-odm+} version 5.1 requires Django 5.1. The minimum supported | ||
Django version is 5.0. | ||
For example, {+django-odm+} version {+django-version+} requires Django {+django-version+}. | ||
The minimum supported Django version is 5.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you end up removing the 5.0
, this might not be relevant, but you shouldn't combine the variables with a hardcoded value because this will become out of date once v6.0 is released. Since this is an example, you can just use hardcoded versions for all of these.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49585
Staging Links
Self-Review Checklist