Skip to content

[JAVA] Remove deprecated event-related classes #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Jan 26, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34456
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/java/docsworker-xlarge/DOCSP-34456/upgrade/#version-5.0-breaking-changes

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + suggestion

Comment on lines 119 to 245
- This driver version removes the following classes from the
``com.mongodb.event`` package:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: My PR hasn't been merged yet, but it changes the language used to introduce these bullet points. We can either leave this bullet point as is for now and come back later to reword, or change it as part of this ticket to match the changes in my PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, there's going to be a few changes required to several PRs - once yours is merged, we can start rebasing the other ones, and account for those changes.

@rachel-mack rachel-mack merged commit e723689 into mongodb:master Feb 9, 2024
@rachel-mack rachel-mack deleted the DOCSP-34456 branch February 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants