Skip to content

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Feb 27, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-NNNNN
Staging - Quick Reference (you can see that {+full-version+} has been dereferenced in the "Install the Driver Dependency with Maven" section.

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one change needed.

@@ -19,7 +19,7 @@ sharedinclude_root = "https://raw.githubusercontent.com/10gen/docs-shared/main/"
driver = "java"
driver-long = "MongoDB Java Driver"
driver-short = "Java driver"
version = "4.11"
version = "5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:
I think the "full-version" source constant below indicates that the release is 5.0.1 rather than 5.0.0.

Suggestion:
Update "full-version" to "{+version+}.0"

@rachel-mack rachel-mack merged commit 9a6c9b6 into mongodb:master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants