Skip to content

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Mar 4, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35704
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/java/docsworker-xlarge/DOCSP-35704/upgrade/#version-5.0-breaking-changes

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + a suggestion!

Comment on lines 121 to 122
For more information, see the `Observable trait documentation
<https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Not necessary, but I think it would be helpful to further clarify where this links to

Suggested change
For more information, see the `Observable trait documentation
<https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
For more information, see the `Observable
<https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__ trait in the Scala API documentation.

@rachel-mack rachel-mack merged commit c52ea19 into mongodb:master Mar 5, 2024
@rachel-mack rachel-mack deleted the DOCSP-35704 branch March 5, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants