Skip to content

DOCSP-43906: crypt shared embedding #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2024
Merged

DOCSP-43906: crypt shared embedding #575

merged 2 commits into from
Sep 27, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 26, 2024 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43906
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for docs-java ready!

Name Link
🔨 Latest commit a45b2aa
🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/66f6c2a9a50ffc00085b360d
😎 Deploy Preview https://deploy-preview-575--docs-java.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir requested a review from jyemin September 26, 2024 21:23
@rustagir
Copy link
Contributor Author

@jyemin @vbabanin tagging you both for this first review, for the other drivers I will not.
On this PR it would also be useful to leave a comment for the compatible/min versions of mongodb-crypt for some of the recent driver versions maybe v4.11 onwards? So that I can backport this PR and populate the note with the correct info.

jyemin
jyemin requested changes Sep 27, 2024
View reviewed changes
@rustagir rustagir requested a review from jyemin September 27, 2024 14:35
norareidy
norareidy approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustagir rustagir merged commit b4618c1 into mongodb:master Sep 27, 2024
5 checks passed
rustagir added a commit that referenced this pull request Sep 27, 2024
@rustagir
DOCSP-43906: crypt shared embedding (#575)
051c37c 
* DOCSP-43906: crypt shared embedding

* add install instructions

(cherry picked from commit b4618c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@norareidy norareidy norareidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @jyemin @norareidy