-
Notifications
You must be signed in to change notification settings - Fork 10
DOCSP-51320: Document causal consistency #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-51320: Document causal consistency #108
Conversation
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-kotlin-sync processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a fix for the replacement variables in the include I think 👍
source/crud/transactions.txt
Outdated
.. replacement:: ReadConcern.MAJORITY | ||
|
||
``majority`` | ||
|
||
.. replacement:: WriteConcern.MAJORITY | ||
|
||
``majority`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[i] I don't think these are rendering correctly (if I'm looking in the correct section in the preview). Should this be adding majority
to the bullet points about read concern and write concern in the requirements list? In the Java docs the replacement variables are majority-rc
and majority-wc
so maybe that needs an update here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 I put the values in the variable name slot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-51320
Staging Links
Self-Review Checklist