Skip to content

DOCSP-51320: Document causal consistency #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jul 8, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51320

Staging Links

  • crud/transactions
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?

    Copy link

    netlify bot commented Jul 8, 2025

    Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit 6698a84
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/686d5464f687c10008b5c3ed
    😎 Deploy Preview https://deploy-preview-108--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 8, 2025

    🔄 Deploy Preview for docs-kotlin-sync processing

    Item Details
    🔨 Latest Commit d4b21b94044a454324b5de6c60c8d7dbb93baae4
    😎 Deploy Preview https://deploy-preview-108--docs-kotlin-sync.netlify.app
    🔍 Build Logs View Logs

    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just needs a fix for the replacement variables in the include I think 👍

    Comment on lines 71 to 77
    .. replacement:: ReadConcern.MAJORITY

    ``majority``

    .. replacement:: WriteConcern.MAJORITY

    ``majority``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    [i] I don't think these are rendering correctly (if I'm looking in the correct section in the preview). Should this be adding majority to the bullet points about read concern and write concern in the requirements list? In the Java docs the replacement variables are majority-rc and majority-wc so maybe that needs an update here.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🤦 I put the values in the variable name slot

    @mcmorisi mcmorisi requested a review from stephmarie17 July 8, 2025 17:33
    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mcmorisi mcmorisi requested review from a team and NathanQingyangXu and removed request for a team July 8, 2025 17:43
    Copy link

    @NathanQingyangXu NathanQingyangXu left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit 4265714 into mongodb:comp-cov Jul 9, 2025
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-51320-causal-consistency branch July 9, 2025 13:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants