Skip to content

DOCSP-51324: Network Compression #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jul 8, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51324

Staging Links

  • connect/connection-options/network-compression
  • connect
  • connect/connection-options
  • connect/connection-options/csot
  • connect/connection-options/stable-api
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Jul 8, 2025

    Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit 7c30bb0
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/6878fbad53f4fd00075fb1cc
    😎 Deploy Preview https://deploy-preview-110--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 8, 2025

    🔄 Deploy Preview for docs-kotlin-sync processing

    Item Details
    🔨 Latest Commit e2f8838d382a3fa7be057148b4944d6c5bbe8e26
    😎 Deploy Preview https://deploy-preview-110--docs-kotlin-sync.netlify.app
    🔍 Build Logs View Logs

    Copy link
    Contributor

    @mballard-mdb mballard-mdb left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Very nice! Left a few suggestions/comments (this is my first solo bigger PR review so may not be super accurate)

    @mcmorisi mcmorisi requested a review from mballard-mdb July 9, 2025 15:24
    Copy link
    Contributor

    @mballard-mdb mballard-mdb left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm!

    @mcmorisi mcmorisi requested review from a team and vbabanin and removed request for a team July 9, 2025 15:31
    @vbabanin
    Copy link
    Member

    Looks good! I noticed that the existing Java sync page and this Kotlin sync one differ in content, with the Kotlin version providing more detail. Do we have plans to update the Java sync page as well to align the content (aside from the examples)?

    @mcmorisi mcmorisi merged commit 6f62210 into mongodb:comp-cov Jul 17, 2025
    5 of 6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-51324-compression branch July 17, 2025 13:34
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants