-
Notifications
You must be signed in to change notification settings - Fork 10
DOCSP-51349: Upgrade guide #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-kotlin-sync processing
|
source/reference/upgrade.txt
Outdated
dependency versioning to match the versioning for the JVM drivers. Future versions of | ||
``mongodb-crypt`` will be released alongside the driver and will share the same version number. | ||
You must upgrade your ``mongodb-crypt`` dependency to v5.2.0 when upgrading your driver for | ||
this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewer: additional breaking change from the Kotlin what's new page
source/reference/upgrade.txt
Outdated
not include comma characters in the ``authMechanismProperties`` connection | ||
string value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewer: additional breaking change from the Kotlin what's new page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job, a few comments and questions to address
source/reference/upgrade.txt
Outdated
changes between the current and upgrade versions. For example, if you | ||
are upgrading the driver from v5.0 to v5.5, address all breaking changes from | ||
the version after v5.0 including any listed for v5.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the version after v5.0 including any listed for v5.5. | |
the versions after v5.0 including any listed for v5.5. |
source/reference/upgrade.txt
Outdated
- Revises the `mongodb-crypt <https://mvnrepository.com/artifact/org.mongodb/mongodb-crypt>`__ | ||
dependency versioning to match the versioning for the JVM drivers. Future versions of | ||
``mongodb-crypt`` will be released alongside the driver and will share the same version number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``mongodb-crypt`` will be released alongside the driver and will share the same version number. | |
``mongodb-crypt`` are released alongside the driver and share the same version number. |
source/reference/upgrade.txt
Outdated
This driver version introduces the following breaking changes: | ||
|
||
- When using the ``MONGODB-OIDC`` authentication mechanism, you must |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When using the ``MONGODB-OIDC`` authentication mechanism, you must | |
- When using the ``MONGODB-OIDC`` authentication mechanism, you must |
what happens if you do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only info about the consequences I can find is in the DRIVERS ticket, which says the driver "will parse connection strings ambiguously." I think it just would result in unexpected behavior due to how it's parsed? not sure if that's worth mentioning here, but I added a suggestion to pass the value in the MongoClientSettings instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that works
To view breaking changes for earlier driver versions, see the | ||
:github:`Release Notes <mongodb/mongo-java-driver/releases>` in the | ||
``mongo-java-driver`` GitHub repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed to the link for release notes in the mongo kotlin driver repo instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kotlin driver folder is in the mongo-java-driver repo, i don't think there are specific Kotlin release notes (unless I'm missing something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see, thanks for checking in on that!
source/reference/upgrade.txt
Outdated
This driver version introduces the following breaking changes: | ||
|
||
- When using the ``MONGODB-OIDC`` authentication mechanism, you must |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When using the ``MONGODB-OIDC`` authentication mechanism, you must | |
- When using the ``MONGODB-OIDC`` authentication mechanism, you cannot |
source/reference/upgrade.txt
Outdated
|
||
You cannot use a 3.x version of the {+driver-short+} to connect to a | ||
MongoDB deployment running {+mdb-server+} v8.1. Starting in {+mdb-server+} v8.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MongoDB deployment running {+mdb-server+} v8.1. Starting in {+mdb-server+} v8.1, | |
MongoDB deployment running {+mdb-server+} v8.1 or later. Starting in {+mdb-server+} v8.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Pull Request Info
PR Reviewing Guidelines
Note to reviewer: The breaking changes are the same as the Java sync changes, with a couple additions from the Kotlin Sync What's New page. I added PR comments where I made these updates.
JIRA - https://jira.mongodb.org/browse/DOCSP-51349
Staging Links
Self-Review Checklist