-
Notifications
You must be signed in to change notification settings - Fork 10
DOCSP-41121 Connect to Mongo Client #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-41121 Connect to Mongo Client #34
Conversation
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things!
source/connect/mongoclient.txt
Outdated
:ref:`kotlin-sync-connection-options` for a full description of | ||
these options. | ||
|
||
.. Is there relevant connection string content for kotlin sync to ref to? Only see for java sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would confirm with the Java DBX team but it's usually the case that Java and Kotlin content overlaps heavily.
When in doubt, we can always link readers to the Server manual for more general-purpose reading on a subject.
.. Is there relevant connection string content for kotlin sync to ref to? Only see for java sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jyemin, do you know if the connection string information for java sync is applicable for kotlin sync? I would like to link to connection string information on this page. This is the connection string page for java sync: https://www.mongodb.com/docs/manual/reference/connection-string/?tck=docs_driver_python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, connection string info is exactly the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
source/connect/mongoclient.txt
Outdated
these options. | ||
|
||
For more information about creating a connection string, see | ||
:manual:`Connection Strings </reference/connection-string?tck=docs_driver_java_sync>` in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:manual:`Connection Strings </reference/connection-string?tck=docs_driver_java_sync>` in the | |
:manual:`Connection Strings </reference/connection-string?tck=docs_driver_java_sync>` in the |
Is the tck
correct for the java sync language in the selector? @mcmorisi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java Sync is probably the closest match but it's still technically a different language (despite sharing a lot of syntax with Kotlin). I see that there's no option in the dropdown for kotlin, so I think we can remove the ?tck=docs_driver_java_sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ddf178e
to
1e73d86
Compare
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41121
Staging - https://preview-mongodblindseymoore.gatsbyjs.io/kotlin-sync/DOCSP-41121-create-mongoclient/connect/mongoclient/
Self-Review Checklist