Skip to content

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Aug 8, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41121
Staging - https://preview-mongodblindseymoore.gatsbyjs.io/kotlin-sync/DOCSP-41121-create-mongoclient/connect/mongoclient/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for docs-kotlin-sync ready!

Name Link
🔨 Latest commit 3c63a76
🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin-sync/deploys/66be5a6aea5cc000086e38d5
😎 Deploy Preview https://deploy-preview-34--docs-kotlin-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things!

:ref:`kotlin-sync-connection-options` for a full description of
these options.

.. Is there relevant connection string content for kotlin sync to ref to? Only see for java sync.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would confirm with the Java DBX team but it's usually the case that Java and Kotlin content overlaps heavily.

When in doubt, we can always link readers to the Server manual for more general-purpose reading on a subject.

Suggested change
.. Is there relevant connection string content for kotlin sync to ref to? Only see for java sync.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jyemin, do you know if the connection string information for java sync is applicable for kotlin sync? I would like to link to connection string information on this page. This is the connection string page for java sync: https://www.mongodb.com/docs/manual/reference/connection-string/?tck=docs_driver_python

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, connection string info is exactly the same.

@lindseymoore lindseymoore requested a review from mcmorisi August 9, 2024 21:44
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lindseymoore lindseymoore requested review from a team and jyemin and removed request for a team August 12, 2024 20:22
these options.

For more information about creating a connection string, see
:manual:`Connection Strings </reference/connection-string?tck=docs_driver_java_sync>` in the
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:manual:`Connection Strings </reference/connection-string?tck=docs_driver_java_sync>` in the
:manual:`Connection Strings </reference/connection-string?tck=docs_driver_java_sync>` in the

Is the tck correct for the java sync language in the selector? @mcmorisi

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java Sync is probably the closest match but it's still technically a different language (despite sharing a lot of syntax with Kotlin). I see that there's no option in the dropdown for kotlin, so I think we can remove the ?tck=docs_driver_java_sync

Copy link

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lindseymoore lindseymoore force-pushed the DOCSP-41121-create-mongoclient branch from ddf178e to 1e73d86 Compare August 15, 2024 19:41
@lindseymoore lindseymoore merged commit ebfdafe into mongodb:master Aug 15, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants