DOCSP-44292: improve i&h #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
approved these changes
Oct 15, 2024
source/issues-and-help.txt
Outdated
Comment on lines
61
to
67
| To get started check out the source and work on a branch: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ git clone https://github.com/mongodb/mongo-java-driver.git | ||
| $ cd mongo-java-driver | ||
| $ git checkout -b myNewFeature |
There was a problem hiding this comment.
S: I think you can reword this code intro slightly; also, you can remove the $ from the code example
Suggested change
| To get started check out the source and work on a branch: | |
| .. code-block:: bash | |
| $ git clone https://github.com/mongodb/mongo-java-driver.git | |
| $ cd mongo-java-driver | |
| $ git checkout -b myNewFeature | |
| To get started, clone the source repository and work on a branch by running the following commands: | |
| .. code-block:: bash | |
| git clone https://github.com/mongodb/mongo-java-driver.git | |
| cd mongo-java-driver | |
| git checkout -b myNewFeature |
source/issues-and-help.txt
Outdated
| $ cd mongo-java-driver | ||
| $ git checkout -b myNewFeature | ||
|
|
||
| Finally, ensure that the code passes gradle checks. |
There was a problem hiding this comment.
S:
Suggested change
| Finally, ensure that the code passes gradle checks. | |
| Finally, ensure that the code passes gradle checks by running the following command: |
source/issues-and-help.txt
Outdated
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ ./gradlew check |
There was a problem hiding this comment.
S:
Suggested change
| $ ./gradlew check | |
| ./gradlew check |
rustagir
added a commit
that referenced
this pull request
Oct 15, 2024
* DOCSP-44292: improve i&h * NR PR fixes 1 * avs changes (just while im in the pr) (cherry picked from commit 8756e14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44292
Staging - https://deploy-preview-51--docs-kotlin-sync.netlify.app/issues-and-help/
Self-Review Checklist