-
Notifications
You must be signed in to change notification settings - Fork 59
DOCSP-47758-history-command #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-47758-history-command #396
Conversation
✅ Deploy Preview for docs-mongodb-shell ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % 2 non-blocking nits.
@addaleax please review. Thanks. |
source/logs/command-history.txt
Outdated
' let salesCollection = JSON.parse( db.sales.find().toArray() ) ', | ||
' let salesCollection = JSON.parse( db.sales.find() ) ', | ||
' let salesCollection = EJSON.stringify( db.sales.find().toArray() ) ', | ||
" fs.writeFileSync( 'salesDeserialize.json', salesCollection ) ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the indentation? Not saying it's bad, just surprising
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used different example
@@ -32,3 +32,37 @@ text editor: | |||
|
|||
* - Windows | |||
- ``%UserProfile%/.mongodb/mongosh/mongosh_repl_history`` | |||
|
|||
Starting in |mdb-shell| 2.4.0, you can use the ``history()`` command to | |||
view a list of previously executed commands. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should state somewhere that the history is returned in chronological order (as opposed to reverse chronological order, which is also a popular choice in other tools)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
DESCRIPTION
STAGING
https://deploy-preview-396--docs-mongodb-shell.netlify.app/reference/access-mdb-shell-help/#command-helpers
https://deploy-preview-396--docs-mongodb-shell.netlify.app/logs/command-history/#steps
JIRA
https://jira.mongodb.org/browse/DOCSP-47758
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?